The current implementation to set a text area as readonly uses the disabled attribute but in IE scrollbars do not work with that attribute and we have a long terms of service we want people to agree to.

I think the attribute <textarea readonly=""> would be better to use because that works in IE with scrollbars.

Comments

quicksketch’s picture

Title: Read Only Text Area in IE » Use "readonly" instead of "disabled" for textarea results

Webform has a generally larger issue that the form shouldn't be used for viewing results at all, but this could be a quick modest improvement over using disabled elements.

deviantintegral’s picture

Version: 5.x-2.1 » 5.x-2.x-dev
StatusFileSize
new1.02 KB

Here's a patch fixing this against the Drupal 5 version, but it also applies cleanly to the Drupal 6 version. Hopefully this can be committed to the next release.

Enjoy!
--Andrew

deviantintegral’s picture

Status: Active » Needs review
quicksketch’s picture

StatusFileSize
new11.07 KB

I've delayed putting in this patch since it doesn't account for other fields (email, textfield, hiddens) that would benefit from this change as well. Here's a patch that affects all components and tidies up the code styling a bit for the display functions.

quicksketch’s picture

Status: Needs review » Fixed

I went ahead and committed the changes. Please reopen if these caused other issues or don't work as expected.

deviantintegral’s picture

I didn't test this, but did read over the code and it looks good. Thanks!

--Andrew

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.