I havnt been able to test the new commit for teasers and full nodes http://drupal.org/cvs?commit=127034 as I am not using the image module on any of my sites, but it doesnt seem to work for image fields in teasers, the views imagecache formatters fix http://drupal.org/cvs?commit=126792 did work great, but only on view types that use fields. Any ideas? I'm playing with the code right now, but no luck.

CommentFileSizeAuthor
#14 piclenslightboxlinux.png507.35 KBswentel
#14 piclensliteflexie6.png473.14 KBswentel

Comments

swentel’s picture

I'll play around this friday with the teaser / imagefield setup on my local machine. Can you describe a bit your setup ? (name of imagefield, views setup - if possible, try and export your views so I can import it into my views installation)

joncup’s picture

Here is my views export. Now, Im not sure if this makes much difference, I use the oaliquid view type, it should work same as the teaser view, in fact, I use oaliquid field view on http://test.DOMAIN.net/tree-moving (that works with current module) and oaliquid teaser on http://test.DOMAIN.net replace DOMAIN with "jony" to see the examples.

This view only shows views of type "tree" witch has a imagefield "field_tree_image", now heres the wierd part, I have the image field set to HIDDEN, it doesnt show in the view, I use node-tree.tpl.php to control what image cache profile should be shown depending on the users role. I dont think this should make much a difference as the imagefield should still be available to the view. I have tested with the current module with the thumbnail set to display in the content tree options and it still doesnt work.

let me know if you need more input, my email is joncup at gmail dot com, or use my contact form.

one more thing, this is the module i use for views output, oaliquid, http://drupal.org/project/oaliquid
this module is very cool, thats why my pages on test.DOMAIN.net look so cool, liquid layout and views fit into the screen size.

  $view = new stdClass();
  $view->name = 'frontpage_new';
  $view->description = 'New trees view.';
  $view->access = array (
);
  $view->view_args_php = '';
  $view->page = TRUE;
  $view->page_title = '';
  $view->page_header = '<p>Here are all trees added in the last 30 days.</p>';
  $view->page_header_format = '1';
  $view->page_footer = '';
  $view->page_footer_format = '1';
  $view->page_empty = '<p>There is no new trees. Please check back again, we add new trees to the site all the time.</p>';
  $view->page_empty_format = '1';
  $view->page_type = 'oaliquid';
  $view->url = 'trees/new';
  $view->use_pager = TRUE;
  $view->nodes_per_page = '30';
  $view->menu = TRUE;
  $view->menu_title = 'New Arivals';
  $view->menu_tab = TRUE;
  $view->menu_tab_weight = '-5';
  $view->menu_tab_default = TRUE;
  $view->menu_tab_default_parent = NULL;
  $view->menu_tab_default_parent_type = 'existing';
  $view->menu_parent_tab_weight = '0';
  $view->menu_parent_title = 'All Trees';
  $view->sort = array (
    array (
      'tablename' => 'node',
      'field' => 'sticky',
      'sortorder' => 'DESC',
      'options' => '',
    ),
    array (
      'tablename' => 'node',
      'field' => 'created',
      'sortorder' => 'DESC',
      'options' => 'normal',
    ),
  );
  $view->argument = array (
    array (
      'type' => 'node_feed',
      'argdefault' => '2',
      'title' => 'Site Name Santized - We specialize in large specimen tree relocations...',
      'options' => 'Site Name Santized - We specialize in large specimen tree relocations...',
      'wildcard' => '',
      'wildcard_substitution' => '',
    ),
    array (
      'type' => 'mediarss',
      'argdefault' => '2',
      'title' => 'Locate My Tree - Newest Specimens',
      'options' => 'link_javascript',
      'wildcard' => '',
      'wildcard_substitution' => '',
    ),
  );
  $view->field = array (
    array (
      'tablename' => 'node_data_field_tree_image',
      'field' => 'field_tree_image_fid',
      'label' => '',
      'handler' => 'content_views_field_handler_group',
      'options' => 'thumbnail_default',
    ),
  );
  $view->filter = array (
    array (
      'tablename' => 'node',
      'field' => 'created',
      'operator' => '>',
      'options' => '-2592000',
      'value' => 'now',
    ),
    array (
      'tablename' => 'workflow_node',
      'field' => 'sid',
      'operator' => 'AND',
      'options' => '',
      'value' => array (
  0 => '4',
),
    ),
  );
  $view->exposed_filter = array (
  );
  $view->requires = array(node, node_data_field_tree_image, workflow_node);
  $views[$view->name] = $view;
joncup’s picture

one more thing, maybe this should be a seperate issue but if you look at the piclens view for http://test.DOMAIN.net/tree-moving the favicon shows up on the top of the screen, but no site name

swentel’s picture

Ah, it's probably because the views type isn't recognized by piclens.
Could you do a little test and open up piclens_views.module and go to line 160:

if ($view_type == 'teaser' || $view_type == 'node') {

Try changing it to:

if ($view_type == 'teaser' || $view_type == 'node' || $view_type == 'oaliquid') {

(note, the piclens_views code isn't the most ideal at this point, once everything works, Im going to refactor it big time)

As for comment #3, I'll add the <title> tag to the head of the rss feed and auto fill in the site name in the next commit (good catch btw).

joncup’s picture

That was the first thing that I tried. I also changed the view to teaser type and still no luck, I even set the imagefield in the content type settings to show the image field in teasers. I'll give it a go again today some time and double check everything.

swentel’s picture

@joncup, can you change the line

if ($view_type == 'teaser' || $view_type == 'node') {

to

if ($view_type != 'list' && $view_type != 'table') {

Did a quick test and runs fine and also other configurations keep working.

swentel’s picture

ok so the line should be

if ($view_type != 'list' && $view_type != 'table' && $view_type != 'oaliquid_list') {

damn ,views support can be hard sometimes :)

joncup’s picture

Hi swentel, I updated to the latested dev today, and even with the new changes as stated in #7 there is no change.
http://test.SITENAME.net/piclens/piclens_views/frontpage_new (replace site name with jony) still is funky, no file names, just the beggining of the path.

Unrelated to this issue, I noticed with another view I have, http://test.SITENAME.net/tree-moving (replace site name with jony)
This is a content type page with an embeded oaliquid list view. Mostly everything works, except...

The slideshow link doesnt start a slideshow, it just opens pic lens and shows all the thumbnails.

And there is no blue play button on the thumbnails on the page, pic lens light doesnt seem to function here.

Also I noticed one of the images, boxing_0213.jpg, does not load in pic lens, only the thumbnail. If you look at the mediarss the url for that file seems fine, you can even click on it in the feed and it loads great, but pic lens freaks out. That might just be an issue with piclens, not your module.

joncup’s picture

I think this error I'm getting is related... when ever i go to a view that uses piclens views module, I get a few diffrent errors..

Unknown column 'n.node_sticky' in 'where clause' query: SELECT n.nid, n.vid, n.type, n.status, n.created, n.changed, n.comment, n.promote, n.sticky, r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, r.format, u.uid, u.name, u.picture, u.data FROM node n INNER JOIN users u ON u.uid = n.uid INNER JOIN node_revisions r ON r.vid = n.vid WHERE n.nid = '63' AND n.node_sticky = '0' AND n.node_created_created = '1214090051' in /var/www/htdocs/includes/database.mysql.inc on line 172.

Unknown column 'n.node_created_created' in 'where clause' query: SELECT n.nid, n.vid, n.type, n.status, n.created, n.changed, n.comment, n.promote, n.sticky, r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, r.format, u.uid, u.name, u.picture, u.data FROM node n INNER JOIN users u ON u.uid = n.uid INNER JOIN node_revisions r ON r.vid = n.vid WHERE n.nid = '19' AND n.node_created_created = '1213335559' in /var/www/htdocs/includes/database.mysql.inc on line 172.

swentel’s picture

Hmm, the sticky and created error are weird that they are there .. seems more like a views error (maybe related with oaliquid) - not sure yet. I'm going to investigate more this weekend and probably completely rewrite the views code of piclens. More news later!

swentel’s picture

I commited the new code (http://drupal.org/cvs?commit=129752) with the best views support I can think of now. Could you try it out when you have some time ?

joncup’s picture

wow, so far so good, working like a charm. good work.

joncup’s picture

Just one issue so far, the start slideshow link doesnt seem to start a slideshow. Other than that this is working great.

swentel’s picture

StatusFileSize
new473.14 KB
new507.35 KB

Great!
Strange thing is, when clicking on the slideshow link, everything works great here:
Tested on ff 3 - linux (on this machine the lightbox from piclens launches cf screenshot), ie6 xp (flash piclens, cf screenshot), ie 7 on vista and ff3 on win xp (piclens launched fine)
There's a javascript error on ie6 on xp when clicking but it starts though .. Not sure why it doesn't work on you machine, maybe a popup blocker (or another toolbar in your browser ?).

But we are very close to a next (great) release, thanks for all the reports and testing!

swentel’s picture

Status: Active » Fixed

Marking as fixed.
Once this is automatically closed within two weeks, a new release will be rolled out!

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.