Jump to:
| Project: | Drupal core |
| Version: | 5.8 |
| Component: | base system |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
A little hard to explain; but hopefully our example will be clear. At first it appeared to be a critical bug; but now more of an annoyance - but still a bug. Also, this is tested on Drupal 5.8; but i am sure it exists in HEAD.
The basic issue was this (my working example):
- sites/site1.mydomain.com
- sites/site1.peter
- in sites/site1.peter there was a liquid.module that was being used on the site http://site1.mydomain.com even though this module doesn’t show in the admin/build/modules list and even though it is not in a site folder that should be seen
- there was an entry in the system table to this module with the path to the actual incorrect site folder; this causes Drupal to load the module (even though it doesn't show on admin/build/modules)
This is all pretty bad; but the part that makes it less bad is that the db was copied over to the db for site1.mydomain.com from my devel site which is site1.peter which would have had an entry to that module in the system folder from usage on that site.
The bug: when going to admin/build/modules Drupal goes through the correct module folders:
- sites/site1.mydomain.com
- sites/all
- modules
and builds or remaps any modules that it finds - BUT, it doesn’t go through the system table entries and remove old module entries that are not in those folders. If the entry in the system table is manually removed; it does not come back (that would be very bad).
Again, this is not that severe but it it is a bug and is dangerous for any developers who work on a test system and production system and maintain the 2 using the multisite concepts built in to Drupal.
Comments
#1
I posted a detailed issue with steps to reproduce at #289369: Deleted modules are not removed from system table so I'm going to mark this as duplicate.
#2
Hey David,
Read your post that you stated was duplicate - pretty sure that is not what i am describing here. And don't think your patch fixes my issue (but not entirely sure).
My issue is re: the multisite issue where i have a module in a multisite folder and then i copy that development db over to another site. The module does not exist in a folder that can be seen from ms #2 but entry still exists in system table; pointing to module in ms #1 folder. When i go to module admin page, the actual module folders are read and used to update the system table (with new entries).
I think your patch suggests that if the file doesnt exist then remove the system entry. In my test case, the module DOES still exist.. just not for that site. So entry remains and the code from the module in ms#1 runs, even though i should never be able to see it in ms #2.
#3
Considering the time elapsed between now and the last comment plus the fact that D5 is no longer supported, I am closing this ticket.