menu suggested items do not show in menu

For comparison purposes, this is how it was done in D5:

    foreach (taxonomy_get_vocabularies($type = NULL) as $vocabulary) {
      $items[] = array(
        'title' => $vocabulary->name,
        'path' => "tagadelic/chunk/$vocabulary->vid",
        'callback' => 'tagadelic_page_chunk',
        'access' => user_access('access content'),
        'type' => MENU_SUGGESTED_ITEM);
    }

I had the same problem with directory.module.
The solution is to completely restore most of the D5 code which, in this case, is completely valid for D6.
Don't use the wildcard loader.

Here is the valid D6 code for directory.module:

  $vocabularies = taxonomy_get_vocabularies();
  foreach ($vocabularies AS $vid => $vocabulary) {
    $items['directory/vocabulary/' . $vocabulary->vid] = array(
      'title' => t('Directory for !vocabulary-name', array('!vocabulary-name' => $vocabulary->name)),
      'page callback' => 'directory_vocabulary_page',
      'page arguments' => array(2),
      'access arguments' => array('access content'),
      'type' => MENU_SUGGESTED_ITEM,
    );
  }

I noticed this bug with my own module (directory.module). I knew that tagadelic has a similar menu structure and that's why I checked it out.

I was using core taxonomy_vocabulary_load() function (used with the wildcard). The code worked fine as a callback. The problem is that there is no menu item ready to be enabled, like it is supposed to do.

This is the code I had just after upgrading to D6:

  $items['directory/vocabulary/%taxonomy_vocabulary'] = array(
    'title callback' => 'directory_vocabulary_title',
    'title arguments' => array(2),
    'page callback' => 'directory_vocabulary_page',
    'page arguments' => array(2),
    'access arguments' => array('access content'),
    'type' => MENU_SUGGESTED_ITEM,
  );

As I said, it worked nice as a MENU_CALLBACK, but did not fulfill its function as MENU_SUGGESTED_ITEM.

The HEAD version of directory.module uses the code in #2, which works as intended.

So, if the foreach loop is wrong, how do I get MENU_SUGGESTED_ITEM without it?

tagadelic has exactly the same problem.

Here is the official way to fix this particular bug.

> In most cases, you DO want to remove the foreach() loop you had in D5.

there, I fixed for you :)

> Within D6, it is ALMOST NEVER NEEDED TO HAVE a loop, recursively declaring several
> well defined menu items, e.g. one item for each vocabulary. When you have
> such a loop, DO use the wildcard loader.

there, I fixed for you :)

You forgot about the distinction of router items and menu links. You will want to use a single router item and save several links with menu_link_save as you see fit.

Regards

Karoly Negyesi

Thanks to karoly for the feedback.