Patch To Add User Profile Search [#28325]

Comment	File	Size	Author
#14	search_profiles_0.patch	5.93 KB	Steven

#13	search_profiles.patch	4.28 KB	Steven

#10	profile_search.patch	3.68 KB	Steven

#9	profilesearch_1.patch	1.97 KB	budda

#8	profilesearch_0.patch	1.98 KB	budda

	profilesearch.patch	1.88 KB	jjeff

Comment #1

moshe weitzman CreditAttribution: moshe weitzman commented 6 August 2005 at 03:16

profile.module is only 1 component of the profile page. other modules plug in using hook_user, and i'd like for those same modules to participate in profile search.

this patch is useful still, but i'm hoping we can do better.

Log in or register to post comments

Comment #2

jjeff CreditAttribution: jjeff commented 6 August 2005 at 22:50

Moshe, are you suggesting some sort of hook that modules would/should implement in order to have their contributions searchable? Say for instance:

hook_user($op, $blah, $blah){
  switch ($op) {
    case 'search':
      // return an array with SQL additions to user search
       $array = array('joins' => array('my_table')), 'columns' => array('column1' , 'column2'));
       // array of returned 'joins' will be impleded with "LEFT JOIN"
       // array of returned 'columns' will be imploded with ', '
       /* end result looks something like
        "SELECT * FROM {users} u LEFT JOIN {my_table} x ON u.uid = x.uid WHERE (u.username LIKE '%%s%') OR (x.column1 LIKE '%%s%') OR (x.column2 LIKE '%%s%')";
        */
    return $array;
    case 'search results':
      // return rendering for search results??
      // does 'view' work for this?

I don't really think that there should be separate searches for "user" and "profile", but I'm having a hard time coming up with a good way of creating a SQL call that doesn't make the server cough and sputter... Like for instance, I don't think that all of those ORs above are going to work very efficiently.

Anyone know of a good way to incorporate the SQL stuff in my patch into the SQL for the user search? Is there a way to search for the same thing accross several columns? That would at least unify the searching for user.module and profile.module. (Why are these separate modules anyway?)

Then (if this seems like the right way to go) we can tackle some kind of an additional case in the user_hook to handle injections into the search.

As always, comments are appreciated!

-Jeff

Log in or register to post comments

Comment #3

Bèr Kessels CreditAttribution: Bèr Kessels commented 8 August 2005 at 14:57

http://drupal.org/node/28275 is another approach, as moshe proposes. Allthough It goes far beyond the scope of jsut making sear profiles searchable, it still aims at searchability of *anything*. PLease have a look there, too.

Log in or register to post comments

Comment #4

moshe weitzman CreditAttribution: moshe weitzman commented 19 November 2005 at 13:17

Status:

Needs review

» Needs work

Log in or register to post comments

Comment #5

Steven CreditAttribution: Steven commented 21 November 2005 at 15:52

It would be better to just merge user_search() into profile_search(). user_search() on its own is pretty useless, and to the end-user there should just be a single 'user search'.

Log in or register to post comments

Comment #6

Patrick Nelson CreditAttribution: Patrick Nelson commented 6 January 2006 at 15:19

Jjeff,

Is it possible to have this patch upgraded to work for 4.7? It's really useful and, I suspect, used by quite a few Drupalers.

Regards

Patrick

Log in or register to post comments

Comment #7

UncleD CreditAttribution: UncleD commented 6 January 2006 at 15:50

I'd like it too!

Log in or register to post comments

Comment #8

budda

English

Cheshire

CreditAttribution: budda commented 1 February 2006 at 15:08

Status:

Needs work

» Needs review

File	Size
profilesearch_0.patch	1.98 KB

I've updated the patch to 4.7b4/HEAD.

This adds the search functionality to profile.module under a seperate "profiles" tab on the global search page.

I do agree that it would make sense to have it merged with the 'user' search but didn't want to start on that until somebody decides what is best.

For now I think this patch is a suitable edition to the coming 4.7 release of Drupal and should be included.

I've tested searching profile fields which are both public, restricted, and hidden. Access control is honoured.

Search results correctly display all the profile fields - no matter how many categories there might be. The previous patch had a bug which just returned 'Array' in the search result 'snippet'.

Log in or register to post comments

Comment #9

budda

English

Cheshire

CreditAttribution: budda commented 1 February 2006 at 15:23

File	Size
profilesearch_1.patch	1.97 KB

Patch without the SQL wrapped over multiple lines.

Log in or register to post comments

Comment #10

Steven CreditAttribution: Steven commented 1 February 2006 at 16:17

File	Size
profile_search.patch	3.68 KB

untested quickie patch:
- Code style (spacing around operators and foreach)
- Remove user_search()
- Add matching of username to search

I'm slightly worried about performance of the SQL query, needs more testing really.

Log in or register to post comments

Comment #11

budda

English

Cheshire

CreditAttribution: budda commented 24 February 2006 at 11:05

Steven: what testing procedure do you suggest? I'd like to get this in to profile.module for 4.7 if possible.

Log in or register to post comments

Comment #12

moshe weitzman CreditAttribution: moshe weitzman commented 24 February 2006 at 16:36

to test this one would need to create some regular profile fields and some admin only profile fields (i.e. hidden). then perform searches with authenticated user and as admin and assure that the correct searches return correct results. non admins can't get hits on admin fields.

also test wildcard searching to verifythat it works as documented

Log in or register to post comments

Comment #13

Steven CreditAttribution: Steven commented 28 February 2006 at 14:37

File	Size
search_profiles.patch	4.28 KB

I fixed a couple of bugs in the previous patches:

Only return each user once
Don't select unnecessary fields
Sort results alphabetically (for lack of a better order)

Tested on scratch.drupal.org. The query is quite heavy there (200ms) but for smaller sites it's ideal. I suppose for a dedicated social networking site, you'd need to look towards a more advanced solution.

Log in or register to post comments

Comment #14

Steven CreditAttribution: Steven commented 28 February 2006 at 14:48

File	Size
search_profiles_0.patch	5.93 KB

Forgot to remove admin/user/search from user.module.

Log in or register to post comments

Comment #15

sanduhrs

he/him

German

🇪🇺 Heidelberg, Germany, Europe

CreditAttribution: sanduhrs commented 28 February 2006 at 22:32

Applied your patch to a fresh CVS install.
It's working fine, but I can't say anything about performance.
vg

Log in or register to post comments

Comment #16

mfb

they or he

CreditAttribution: mfb commented 2 March 2006 at 19:44

Would be fabulous if we could have a search API used by all the user-related contrib modules. For instance, the address module -- part of ecommerce which stores first and last name, address, and phone number -- is not (yet) searchable, as far as I can tell.

Log in or register to post comments

Comment #17

budda

English

Cheshire

CreditAttribution: budda commented 23 March 2006 at 13:07

Until/If the search function gets in to profile.module core, i've knocked out a quick module to add searching without the need to keep patching your core profile.module file.

You can find the ProfilePlus module in CVS @ http://drupal.org/node/55469

Log in or register to post comments

Comment #18

dmitrig01 CreditAttribution: dmitrig01 commented 23 June 2007 at 16:36

Version:	x.y.z	» 6.x-dev
Status:	Needs review	» Closed (duplicate)

I think there is some other issue covering this

Log in or register to post comments

Comment #19

moshe weitzman CreditAttribution: moshe weitzman commented 23 June 2007 at 21:10

Status:

Closed (duplicate)

» Needs work

um, this one has a promising patch in it. please demonstrate a better patch before closing this one.

i do much appreciate pruning of the issue queue.

Log in or register to post comments

Comment #20

catch

he/him

English

CreditAttribution: catch commented 24 October 2007 at 14:07

Version:

6.x-dev

» 7.x-dev

Log in or register to post comments

Comment #21

rcross CreditAttribution: rcross commented 20 November 2007 at 05:38

Version:

7.x-dev

» 6.0-beta2

Not sure why this is marked for 7.x - I'm curious if there is the ability to search by more than just username. This seems to do a full text index of the profile - but what about email address or other standard user fields not part of profile.module?

Log in or register to post comments

Comment #22

StevenPatz

he/him

English

Alexandria VA

CreditAttribution: StevenPatz commented 20 November 2007 at 16:21

Features go into 7.x

Log in or register to post comments

Comment #23

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 20 November 2007 at 20:29

Version:

6.0-beta2

» 7.x-dev

That's right. Back to 7.x.

Log in or register to post comments

Comment #24

RobLoach

he/him

CreditAttribution: RobLoach commented 31 January 2008 at 17:17

This post acts as a reminder for me to have a look at this later.

Log in or register to post comments

Comment #25

robertDouglass CreditAttribution: robertDouglass commented 15 April 2008 at 08:49

Note for later: LOWER is the SQL antichrist: WHERE LOWER(pv.value) LIKE LOWER('%%%s%%') OR LOWER(u.name) LIKE LOWER('%%%s%%') so a different solution is desired. Perhaps we should use the search_index table?

Log in or register to post comments

Comment #26

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 3 November 2009 at 17:04

Status:

Needs work

» Closed (fixed)

Cleaning up the issue queue.

Log in or register to post comments

Comment #27

rcross CreditAttribution: rcross commented 8 December 2009 at 02:11

does this mean this is committed? or has been otherwise marked won't-fix?

Log in or register to post comments

Comment #28

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 18 February 2010 at 00:07

Version:	7.x-dev	» 8.x-dev
Status:	Closed (fixed)	» Active

This issue should not have been closed. However, it is too late for Drupal 7 now.

Log in or register to post comments

Comment #29

Damien Tournoud CreditAttribution: Damien Tournoud commented 6 August 2010 at 09:06

Status:

Active

» Closed (won't fix)

The profile module is obsolete. Won't fix.

Log in or register to post comments

Comment #30

mfb

they or he

CreditAttribution: mfb commented 16 August 2010 at 06:49

User module implements the search hooks, allowing user name (and for admins, also user mail) to be searched. With users being fieldable entities, other user fields should arguably be indexed and searchable.

Log in or register to post comments

Comment #31

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 16 August 2010 at 14:45

mfb:
a) This issue is closed, so no one is going to notice your comments here.

b) This issue relates to the profile.module, not to fields on user entities. For what it's worth, the profile module is still a part of D7 core (mostly I think because no one came up with an upgrade path to translate profile module to fieldable user entites).

c) Users are currently not really being indexed for searching. Search users just uses the existing user table to search. If you think fields on user entities should be searchable, that is not a bad idea, but it needs to be filed as a D8 issue, and the way users are currently searchable would need to be overhauled (since the user entities would need to be indexed).