Dear Roberto,

We're testing Storm, and it really looks promising! Some remarks:

1. There should be consistency on how themes are formatted. Sometimes we see "br /" tags, other times "dl" "dt" "dd", and sometimes tables are used.
"dt" "dt" "dd" has our preference over other ways for formatting data.

2. "dl" lists should have 2 denominators: "dt" for the label and "dd" for the value. Now we have only one: "dt" for both. Eg. StormInvoice

3. Buttons and links such as "Print" should not appear in the data list. They should be in a seperate div tag, preferably attributed with a .link class. Eg. StormInvoice

Thanks for looking into it, and keep those releases coming : )

Stefaan

CommentFileSizeAuthor
#3 storm_283373.patch7.28 KBCraig Gardner

Comments

Roberto Gerola’s picture

Category: bug » task
Priority: Critical » Normal

Ok, thanks.

Craig Gardner’s picture

Assigned: Unassigned » Craig Gardner

I'll take a whack at this one.

Craig Gardner’s picture

StatusFileSize
new7.28 KB
Magnity’s picture

Status: Active » Needs review

Changing status as patch present.

Magnity’s picture

Version: 6.x-1.0 » 6.x-1.x-dev
Status: Needs review » Needs work

Tested on current -dev version as that is where it would be implemented.

1) Loses icons on /storm
2) (Less critical) patch method doesn't specify files properly - I had to manually specify which files to patch

Magnity’s picture

Component: Code » Miscellaneous
Assigned: Craig Gardner » Unassigned
Priority: Normal » Minor
Status: Needs work » Closed (fixed)

Closed due to inactivity on this issue.

If anybody wishes to take this up (i'm happy to commit changes to rationalise the themeing etc.) - please reopen.