In style.css I propose to have this margin for .site-slogan:

margin: 0em 0em 0em 0.5em;

The reason is: With large fonts the slogan may go under the logo and will look bad without a margin.

See screenshot where the correct display is shown.

CommentFileSizeAuthor
#3 bluemarine_slogan_margin.diff422 bytesRichard Archer
myscreen.jpg170.06 KBnsk

Comments

gordon’s picture

Project: Bluemarine » Drupal core
Version: 4.6.x-1.x-dev » x.y.z
Component: Code » theme system

this really need to be against the the core version.

Tobias Maier’s picture

why does this have to go into the core system?
I think thats a theme-thing.
In my opinion we should have as less stylesheets in core as possible.
Because all new styles affects the themes and a template designer should not be forced every time to readjust his theme.

ciao tobi

Richard Archer’s picture

Project: Drupal core » Bluemarine
Version: x.y.z » 4.7.x-1.x-dev
Component: theme system » Code
Status: Active » Needs review
StatusFileSize
new422 bytes

I'm putting this back into the bluemarine project because:

  • It is a definite problem with the Bluemarine theme.
  • The other core themes and a couple of contrib themes I have installed do not have this problem.
  • Adding new CSS to core will require all themes to be reviewed to consider the implications of this change and that means this patch will never get committed.
  • Adding new CSS to core is a bad idea in any case... it should be kept as light as possible and themes should do the heavy lifting.
  • I've devised a fix which relates to Bluemarine only... not core :)

I also noticed that under extreme conditions the site name can also wrap under the logo.

Here's a patch that adds a margin to site-name and site-slogan so they line up with the left edge of the logo if they wrap.

Orientador’s picture

Version: 4.7.x-1.x-dev » 4.6.x-1.x-dev
Assigned: Unassigned » Orientador
Category: feature » task
gordon’s picture

Project: Bluemarine » Drupal core
Version: 4.6.x-1.x-dev » 4.6.3
Component: Code » theme system
Priority: Critical » Normal

This version of bluemarine is now in core, any changes need to be applied to core before I will backport them to 4.6

magico’s picture

Category: task » bug

Applied or not?

gordon’s picture

Status: Needs review » Fixed

I have backported bluemarine for 4.7.

Anonymous’s picture

Status: Fixed » Closed (fixed)