Now that Drupal 6.3 is out with jQuery 1.2.6, jQuery_update module is not needed. Can that be removed as a dependency to install the module? Or could the next version just require Drupal 6.3?

Comments

mfer’s picture

mfer commented

Using the jQuery UI that's out right now with D6.3 would work and there wouldn't be a dependency issue. But, that won't be the case in the future. I wonder if it would be better to check the version of jQuery in core and if that's not good enough to check for jQuery Update and what version it has as part of hook_requirements.

mfb’s picture

mfb
they or he
commented

That would be pretty cool

mfer’s picture

mfer commented

So, the issue is a little more complicated above. Our options are 3 fold (I think):

1) Setup jQuery UI to check the core version of core. If that isn't a right version then require the jQuery Update module. Then, have both jQuery UI and jQuery Update have their own compression settings.

2) Setup jQuery UI to check the core version of core. If that isn't a right version then require the jQuery Update module. Then, have both jQuery UI and jQuery Update use the jQuery Update setting when it's installed and just the jQuery UI setting when only that is installed.

3) Leave things are the way they are now.

I'm like the 3rd option. It may be one more module to install and there will be times (like now) when it really isn't needed but from a quick look over this it will be less code and processing a majority of the time.

Thoughts?

designerbrent’s picture

designerbrent commented

While option 2 is probably the best approach, in my thought, as it makes it easier to use, I understand that there would be a lot of extra code. And unfortunately, that is not something that I can write, otherwise I'd be happy to try and write a patch.

All that said, I know enough to hack out the dependency on jquery_update where it is not needed. I'm not a huge fan of having to add more modules if they are not needed but as you said, it may not always be the case so I understand.

mfer’s picture

mfer commented

@designerbrent - It's not as simple as hacking out the dependency. If you do that you will loose part of the jQuery UI module. The jQuery UI and jQuery Update modules provide a means to use uncompressed, minified, and packed versions of jQuery and the UI. The settings to select which to use are in jQuery Update.

jQuery Update isn't just for keeping up with the latest release jQuery. It checks the core version of jQuery and defaults to that when it's the right version. If the core version isn't right or the a compression type other than core is selected it swaps it out.

The logic you are looking for to do the core detection and only replace when needed is what jQuery Update does. To move that over to jQuery UI would double up the logic when the dependency will do nicely.

Basically, when drupal has the up to date version of jQuery the combo of jQuery Update and jQuery UI do number 2 from the above choices.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

I kind of feel like #2, although it's the "right" fix, is a lot of work given that the state of Drupal core and jQuery's latest version matching is bound to be a condition that lasts maybe a maximum of a couple months at most. Once jQuery moves to 1.3.x that's /definitely/ not going to be added to D6 stable, and I'm actually a bit surprised that 1.2.6 was even since there were some API changes between that and 1.2.3.

We did do a bunch of work in jQuery Update module so that it won't load itself unless necessary, however. So the unnecessray requirement is relatively harmless other than the whole "yet another module" thing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Closed (won't fix)

In short... won't fix, I think. Unless someone can come up with a solution that addresses mfer's #5.