Update function missing return array()

Argh. This is a minor WTF of the database update API. Update functions HAVE to return an empty array, even if they executed no SQL queries at all.

This patch adds a return array() to the update function, which should remove the warning.

And as an answer, the update went fine and everything is okay. The warning was caused because the update system expected a status report about success/failure from the module, and didn't get one.

DRUPAL-6--3 is fine. This is now committed for 6.x-2.x-dev.

I just got this error in Drupal 6.8, when running update.php for the latest module updates for the following:
- Statistics Advanced Settings
- Bookmarks

The errors:

array_merge() [function.array-merge]: Argument #2 is not an array in /var/www/example.com/update.php on line 174.

Invalid argument supplied for foreach() in /var/www/example.com/update.php on line 339.

switched status to active.

Well, I'm the module maintainer of statistics advanced settings and I double checked that all my module's update functions return an array. A quick check of the bookmarks module confirms there is an update function missing a return:

function bookmarks_update_6100() {
  db_query("INSERT INTO {menu_bookmarks} VALUES ('defaults','Defaults','The default bookmarks for all users.  This list will be used to pre-populate bookmarks for new users.')");
}

Thx, Dave, for checking and reporting.

--aslam

I updated Bookmarks to 6.x-1.6. I didn't get the error, though there wasn't a db update associated with the 6.x-1.6 update. So, it would seem that the db update of 6.x-1.5 did succeed, despite the error/warning.