Display favorites as a MENU_LOCAL_TASK on user profile

pounard - July 18, 2008 - 14:35
Project:Favorite Nodes
Version:5.x-1.x-dev
Component:User interface
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs work
Description

Default is to display favorites in the user overview.

Is it possible to display those into a new tab (e.g. a MENU_LOCAL_TASK) ?
This things could be configurable via the administration interface.

If you don't have time, I propose mine to do it.

I'm not doing it right now because I don't need this now. But in some weeks, I won't have the choice to do it, I'll do It, please tell me if you are interested to add and maintain such a feature if I develop it.

#1

pounard - July 20, 2008 - 20:55
Status:active» needs review

And I did it, and fixed 2 minor bugs too.

See the patch file here.

I wait for some activity from mainteners, if this patch is good to you, would be great to put it in HEAD :)

AttachmentSize
favorite_nodes.module-5.x-1.2-view_as_local_task.patch 7.37 KB

#2

kbahey - July 20, 2008 - 23:59
Version:5.x-1.2» 5.x-1.x-dev
Status:needs review» patch (to be ported)

Thank you for the patch. It is committed to the 5.x dev version.

Would be nice to have this ported to Drupal 6.

#3

pounard - July 21, 2008 - 07:29

I don't have much time to port it to Drupal 6, if my needs lead to this one day, I'll do it.

#4

pounard - July 22, 2008 - 10:17

I made some bugfix (my errors) and added a feature which permit the administrator to hide empty categories in user favorite listing (working).

This a minor patch, I think it dont deserve intensive test, but I should test and integrate this also if you like.

AttachmentSize
favorite_nodes-5.x-1.2-view_as_local_task-v2.patch 8.61 KB

#5

pounard - July 22, 2008 - 10:18
Status:patch (to be ported)» needs review

#6

kbahey - July 23, 2008 - 03:43
Status:needs review» needs work

Lots of failures. Are you sure this is against the current version of the DRUPAL-5 tag in cvs?

patching file favorite_nodes.module
Hunk #1 succeeded at 12 with fuzz 2.
Hunk #2 FAILED at 37.
Hunk #3 FAILED at 63.
Hunk #4 FAILED at 80.
Hunk #5 succeeded at 109 with fuzz 2 (offset 15 lines).
Hunk #6 FAILED at 140.
Hunk #7 FAILED at 154.
Hunk #8 FAILED at 201.
Hunk #9 succeeded at 352 with fuzz 2 (offset 29 lines).
Hunk #10 succeeded at 374 (offset 29 lines).
Hunk #11 FAILED at 432.
Hunk #12 FAILED at 482.
Hunk #13 FAILED at 551.
Hunk #14 FAILED at 582.
Hunk #15 FAILED at 606.
11 out of 15 hunks FAILED -- saving rejects to file favorite_nodes.module.rej

#7

pounard - July 23, 2008 - 08:57

I put the version on which I did the patch in filename (5.x-1.2).
I can do it on current head version, but I have much work so I wont be able to do it for a few days.

 
 

Drupal is a registered trademark of Dries Buytaert.