Needs work
Project:
Favorite Nodes
Version:
5.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
18 Jul 2008 at 14:35 UTC
Updated:
23 Jul 2008 at 08:57 UTC
Jump to comment: Most recent file
Comments
Comment #1
pounardAnd I did it, and fixed 2 minor bugs too.
See the patch file here.
I wait for some activity from mainteners, if this patch is good to you, would be great to put it in HEAD :)
Comment #2
kbahey commentedThank you for the patch. It is committed to the 5.x dev version.
Would be nice to have this ported to Drupal 6.
Comment #3
pounardI don't have much time to port it to Drupal 6, if my needs lead to this one day, I'll do it.
Comment #4
pounardI made some bugfix (my errors) and added a feature which permit the administrator to hide empty categories in user favorite listing (working).
This a minor patch, I think it dont deserve intensive test, but I should test and integrate this also if you like.
Comment #5
pounardComment #6
kbahey commentedLots of failures. Are you sure this is against the current version of the DRUPAL-5 tag in cvs?
patching file favorite_nodes.module
Hunk #1 succeeded at 12 with fuzz 2.
Hunk #2 FAILED at 37.
Hunk #3 FAILED at 63.
Hunk #4 FAILED at 80.
Hunk #5 succeeded at 109 with fuzz 2 (offset 15 lines).
Hunk #6 FAILED at 140.
Hunk #7 FAILED at 154.
Hunk #8 FAILED at 201.
Hunk #9 succeeded at 352 with fuzz 2 (offset 29 lines).
Hunk #10 succeeded at 374 (offset 29 lines).
Hunk #11 FAILED at 432.
Hunk #12 FAILED at 482.
Hunk #13 FAILED at 551.
Hunk #14 FAILED at 582.
Hunk #15 FAILED at 606.
11 out of 15 hunks FAILED -- saving rejects to file favorite_nodes.module.rej
Comment #7
pounardI put the version on which I did the patch in filename (5.x-1.2).
I can do it on current head version, but I have much work so I wont be able to do it for a few days.