Posted by robertDouglass on July 18, 2008 at 4:17pm
| Project: | Advanced help |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | ff1 |
| Status: | closed (fixed) |
Issue Summary
Placeholder for this effort if/when it happens.
| Project: | Advanced help |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | ff1 |
| Status: | closed (fixed) |
Placeholder for this effort if/when it happens.
Comments
#1
OK, the attached zip file contains the first pass at a backport of the Advanced help module for D5. I used the 6.x-1.0 version to create this.
One problem I had was with theming the popup window. I had to resort to adding a function to template.php. If anyone can think of a better way (one that does not involve adding files to the theme folder or copying code snippets), please let me know.
I've also included an updated version of the help_example module to demonstrate that the functionality works.
I'm sure things can be improved from here, but its a starting point...
#2
The search functionality is still using D6 functions, so it is currently broken. I'll look into this over the weekend.
#3
I'm willing to give maintainer status to you if you wish to run with this, or to anyone who wishes to help maintain a 5.x version of this module. I think the community would benefit from it, as the Drupal 5 line of code will not be dead for at least a couple of years yet.
#4
Thanks for the offer. :-) I'll see how I get on with backporting the search integration before I accept.
#5
Search integration is now complete. There is still a small bug where the popup=true status is lost when a search is submitted within a popup window, but I'll work on that.
Now we really need some testers and a module with some help files to really test it on. Any volunteers?
#6
The problem with searching within a popup window is now fixed. As far as I am concerned, this is now RTBC, but it could do with some independent reviews.
merlinofchaos: I'd be happy to maintain the 5.x version of this module. Thanks :)
#7
You now have commit access. Are you comfortable with branching in CVS? I can create a branch for you if not, but if you are, go to it (just remember that when you create the branch you must also then update to that branch so you don't commit into your old branch =)
#8
OK, so I've now created a DRUPAL-5 branch, committed the changes to it and created a beta release.
I think/hope I did all the CVS stuff right... I certainly read enough docs before leaping in! Please let me know if I've done anything wrong.
Marked this issue as fixed because any bugs with the 5.x code can now be raised against that.
#9
CVS messages look correct to me. Thanks!
#10
Automatically closed -- issue fixed for two weeks with no activity.