statistics.module - Menu issue [#28446]

I am busy upgrading to the latest version of drupal, and i noticed the the following 4 menu items show up directly under the Site Navigation Menu for normal authenticated users (it should only be available for Admin users, and it should show under Administer>logs menu

top pages
top visitors
recent hits
referrers

Thanks for the help!
Cheers
jacauc

http://www.dieinter.net (current production site)
http://www.dieinter.net/backup/sandpit/beta3 (new site - giving me problems)

Comment	File	Size	Author
#4	statistics.module-cvs.patch	1.62 KB	Jeremy
#4
#3	statistics.module-4.6.patch	1.64 KB	Jeremy
#3
	Untitled_0.jpg	30.26 KB	jacauc

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jacauc CreditAttribution: jacauc commented 10 August 2005 at 12:45

Has anyone seen this issue before?

FYI, i have moved the test site into production, so it is now running on http://www.dieinter.net

Please help!

Thanks
jacauc

Comment #2

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 13 August 2005 at 21:26

I think it could have happended that the user in question did not have the "access administarion pages" permission but the "access statistics" permission.

Comment #3

Jeremy CreditAttribution: Jeremy commented 15 August 2005 at 15:48

File	Size
statistics.module-4.6.patch	1.64 KB

Indeed, easily duplicated.

Part of the confision is that pre-4.6 there were two options, "access statistics" and "administer statistics". The former made content view counters visible, the latter made the accesslog visible. The problem was that "access statistics" was redundant with another "make content view counters visible" option on the statistics module configuration page.

Unfortunately, I believe the wrong permission was removed. On my site, I want to be able to let registered users view the view counters (primarily as they are interested in their personal blogs), but not anonymous users.

The attached patch removes the option on the statistics module configuration page, and renames the "access statistics" permission to "access accesslog". Additionally, it adds a new "access content view counters" permission. By default, if content view counters are enabled only the administrator will be able to see them until the permission is assigend to other roles.

I've attached a patch for 4.6.3, as that's what the bug is against. But I'll post another patch for cvs.