Module generates links that do not properly validate as XHTML

That page has no links to scriptures.

Here is the patch code for the 6.x-1.0 version. It is probably the same for the 5 version.

Notice & changed to & in URLs:

switch ($translation) {
case 'ESV':
// note: the ESV could actually support a mouseover reference
// we could pull it directly from their site and include it in the $title text
// http://www.gnpcb.org/esv/share/services/api/ for more info
$link = 'http://www.gnpcb.org/esv/search/?go=Go&q=';
$title = 'English Standard Version Bible';
$link = sprintf('%s',$link,htmlentities(urlencode(trim("$volume $book $verse"))),$title,trim($reference));
break;
case 'NET':
$link = 'http://net.bible.org/passage.php?passage=';
$title = 'New English Translation';
$link = sprintf('%s',$link,htmlentities(urlencode(trim("$volume $book $verse"))),$title,trim($reference));
break;
case 'TNIV':
$link = 'http://www.tniv.info/bible/passagesearch.php?passage_request=';
$title = 'Today\'s New International Version';
$link = sprintf('%s',$link,htmlentities(urlencode(trim("$volume $book $verse"))),$title,trim($reference));
break;
default:
$link = "http://biblegateway.com/cgi-bin/bible?language=english&version=$translation&passage=";
$title = 'Bible Gateway';
$link = sprintf('%s',$link,htmlentities(urlencode(trim("$volume $book $verse"))),$title,trim($reference));
break;
}

I've been able to reproduce this - the problem is that the anchor tags contain href attributes with '&' in, instead of '&'.

Flagged as 7.x, as all bug reports / new features are being developed against the 7.x version of the module for the time being (which does not stop those patches being rerolled against 6.x subsequently).

If someone wants to submit a proper patch file to fix this, they'd be very welcome!

I think the attached solves it. If someone wants to test it, that would be a help.

The attached should work for Drupal 6.

If you could test this one and confirm it works for Drupal 6, that would be half the testing done.

Thanks for testing.

Did you clear the Drupal cache before re-running the test?

Given there are quite a lot of errors / warnings on there that do not relate to Scripture Filter, we need to find out what errors are being caused by this module.

Could you try disabling the Scripture Filter module entirely, clear the Drupal cache, and run the test. Leave the result open, and open a new browser window / tab. Then re-enable the Module, clear the Drupal cache again, and use that new tab to re-run the test. You then have two windows with validation test results open side-by-side, the only difference being that Scripture Filter was being used for one and not for the other.

1. How many additional errors is this module causing?

2. Can you find those additional lines, and post exactly what the W3C validator is complaining about.

Once we know precisely what the reported problem is, we can work to fix it equally precisely.

Committed

I can confirm that the patch has worked on our Drupal 6 installation. We now have a clean bill of health with the W3C code validator. Thank you very much!

Our site is bcconline.org.uk.