Block patch for DRUPAL-5-8
robertDouglass - July 18, 2008 - 21:41
| Project: | Advanced cache |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
The DRUPAL-5-7 block patch didn't apply to DRUPAL-5-8 cleanly. Some of the logic has been changed. The patch needs to be ported/re-rolled for DRUPAL-5-8.
#1
Check the patch.
In the old block_module.patch, the last patch point was looking for the line
<?phpif ($enabled && $page_match) {
?>
where block.module in Drupal 5.8 actually contained in the same place (line 703)
<?phpif ($block->enabled && $block->page_match) {
?>
I created the block patch as if it was looking for
<?phpif ($block->enabled && $block->page_match) {
?>
and it patches to
<?phpif ($block->page_match) {
?>
#2
Did you test it as well? I came to a similar conclusion as you but didn't have time for rigorous testing (still don't), so this has to be reviewed by some people. Thanks.
#3
No, I did not test it, as my time does not permit me to do so.
Testers are always welcome. :-)
#4
This lastest patch applies and works succesfully on Drupal 5.10, thanks!
P.S. In dev version of module I have found a folder DRUPAL-5-8 that doesn't contains path_cache.patch and search_cache.patch and some else. On drupal 5.8 or later I need to use thouse paches from 5.6 folder or newer version of drupal doesn't need them?
#5
Committed, thanks.
#6
path search and forum are currently considered broken, and are not recommended for use.
discussion of path cache problems here:
http://drupal.org/node/293861
http://drupal.org/node/220983
i'm not sure why forum and search are currently deprecated - robert updated the README on july 18th...i'll open some support requests for more info...
#7
Path and forum have been problematic for people (whether reported in issue queue or not). Until we get unit tests that prove their correctness, or large quantities of reports from people that they're working fine, I wanted a warning label. I figure that the meek will stay clear and the inquisitive will probe deeper.
#8
what about search? (i personally don't use it as i have access control modules that would break it...)
sorry, i'll assume it's the same story.
i agree wrt unit tests.
#9
Search caching is more fundamentally broken, imo.
#10
Automatically closed -- issue fixed for two weeks with no activity.