Please add CVS $Id$ tags to all source files in Drupal core. This allows admins to know exactly which version of which files they use. In addition I want to use CVS $Id$ tags in my upcoming security.module to check for possible vulnerabilities. That's not possible if some files simply don't have $Id$s.

Note: I also (mostly) unified the tags to use the "// ID" form instead of "/* ID */", but that's more of a cosmetic issue. I'm not sure whether *.txt files and the stuff in themes/ need tags(?)

CommentFileSizeAuthor
#8 ids46_0.patch2.56 KBUwe Hermann
#6 ids462.patch6.02 KBUwe Hermann
#5 ids46.patch6.02 KBUwe Hermann
ids.patch7.96 KBUwe Hermann

Comments

dries’s picture

dries commented

Committed to HEAD. Thanks.

dries’s picture

dries commented
Status: Needs review » Fixed
Uwe Hermann’s picture

Uwe Hermann commented
Version: x.y.z » 4.6.2
Status: Fixed » Reviewed & tested by the community

Can you please apply the patch to 4.6, too? A potential 4.6.3 release should have the Id-tags, too. Uwe.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

The patch doesn't apply against 4.6.

Uwe Hermann’s picture

Uwe Hermann commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new ids46.patch6.02 KB

Updated patch for 4.6.

Uwe Hermann’s picture

Uwe Hermann commented
StatusFileSize
new ids462.patch6.02 KB

Oops, that was 4.6.0. Here's a patch for 4.6.2.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

Committed to DRUPAL-4-6. Parts of the patch were rejected though so the code needs some more work.

$ patch -p0 < ids462.patch 
patching file database/updates.inc
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file database/updates.inc.rej
patching file includes/common.inc
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file includes/common.inc.rej
patching file includes/file.inc
patching file includes/menu.inc
patching file includes/theme.inc
patching file modules/aggregator.module
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file modules/aggregator.module.rej
patching file modules/path.module
patching file modules/upload.module
patching file scripts/code-clean.sh
patching file scripts/code-style.pl
patching file scripts/cron-curl.sh
patching file scripts/cron-lynx.sh
patching file scripts/prefix.sh
Uwe Hermann’s picture

Uwe Hermann commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new ids46_0.patch2.56 KB

Updated patch (against DRUPAL-4-6).

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to DRUPAL-4-6. Thanks.

Anonymous’s picture

(not verified) commented
Uwe Hermann’s picture

Uwe Hermann commented
Version: 4.6.2 » 4.6.0
Status: Fixed » Closed (fixed)