Download & Extend
Table of Contents » Issues

Option to remove show/hide

Posted by silurius on July 21, 2008 at 5:20am
Project:Table of Contents
Version:6.x-3.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:AlexisWilke
Status:closed (fixed)

Issue Summary

I realize it may be feasible to remove the show/hide link through a hack of some kind, but it would be great to see that included as a feature (unless I've overlooked the fact that it already is).

Login or register to post comments

Comments

#1

Posted by deviantintegral on July 21, 2008 at 8:59pm

Good idea. A few ways I could see this implemented:

  1. As an option in the TOC marker string, which would be per-instance of a TOC
  2. As an option on the filter settings page, to affect the whole site. It would make sense to expose all of the filter defaults on this page anyways.
  3. By breaking the HTML rendering out into a theme function, which could then be overridden in your template.php

      4. What was your use case? Would it fit the above?

      --Andrew

#2

Posted by silurius on July 22, 2008 at 12:09am

Option 1 would work best for me in the use cases I'm thinking of. But you raised a very good question and I imagine it deserves additional input from others.

#3

Posted by deviantintegral on October 19, 2008 at 6:36pm

Well, good news! I've got patches which address option 3, and most of the way to option 2:

Once #296171 lands, I'll add a new option to allow changing of the hide / show toggle, in both the filter settings and per-page.

#4

Posted by deviantintegral on October 19, 2008 at 6:37pm
Status:active» postponed

#5

Posted by deviantintegral on October 29, 2008 at 6:47pm
Status:postponed» needs review

Here is a patch which implements it as a new setting. Please test it and if it looks good I'll port to the 5.x version and commit. Also, now that the module is properly themable, you could easily deal with it by overriding the theme function.

AttachmentSize
285150_show-hide_toggle_6.x_5.patch 4.66 KB

#6

Posted by Flying Drupalist on December 8, 2008 at 3:24pm

works, thank you.

#7

Posted by deviantintegral on January 1, 2009 at 5:55pm

Here is an updated patch and one for D5. I fixed a minor bug in the error checking where the toggle switch would allow strings as they can evaluate to TRUE or FALSE.

AttachmentSize
285150_show-hide_toggle_5.x_7.patch 4.85 KB
285150_show-hide_toggle_6.x_7.patch 4.87 KB

#8

Posted by AlexisWilke on July 5, 2009 at 10:21am
Version:6.x-2.x-dev» 6.x-3.x-dev
Assigned to:Anonymous» AlexisWilke
Status:needs review» fixed

This is done in 3.x-dev. I did not use these patches.

Thank you.
Alexis Wilke

#9

Posted by System Message on July 19, 2009 at 10:30am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#10

Posted by Aren Cambre on November 20, 2009 at 9:32pm
Status:closed (fixed)» active

Needs to be documented.

#11

Posted by AlexisWilke on June 18, 2010 at 9:22am
Status:active» fixed

Closing since this has been working for ages in 3.x.

Thank you.
Alexis

#12

Posted by System Message on July 2, 2010 at 9:30am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.