I realize it may be feasible to remove the show/hide link through a hack of some kind, but it would be great to see that included as a feature (unless I've overlooked the fact that it already is).

CommentFileSizeAuthor
#7 285150_show-hide_toggle_5.x_7.patch4.85 KBdeviantintegral
#7 285150_show-hide_toggle_6.x_7.patch4.87 KBdeviantintegral
#5 285150_show-hide_toggle_6.x_5.patch4.66 KBdeviantintegral

Comments

deviantintegral’s picture

deviantintegral commented

Good idea. A few ways I could see this implemented:

  1. As an option in the TOC marker string, which would be per-instance of a TOC
  2. As an option on the filter settings page, to affect the whole site. It would make sense to expose all of the filter defaults on this page anyways.
  3. By breaking the HTML rendering out into a theme function, which could then be overridden in your template.php

      4. What was your use case? Would it fit the above?

      --Andrew

silurius’s picture

silurius commented

Option 1 would work best for me in the use cases I'm thinking of. But you raised a very good question and I imagine it deserves additional input from others.

deviantintegral’s picture

deviantintegral commented

Well, good news! I've got patches which address option 3, and most of the way to option 2:

Once #296171 lands, I'll add a new option to allow changing of the hide / show toggle, in both the filter settings and per-page.

deviantintegral’s picture

deviantintegral commented
Status: Active » Postponed
deviantintegral’s picture

deviantintegral commented
Status: Postponed » Needs review
StatusFileSize
new 285150_show-hide_toggle_6.x_5.patch4.66 KB

Here is a patch which implements it as a new setting. Please test it and if it looks good I'll port to the 5.x version and commit. Also, now that the module is properly themable, you could easily deal with it by overriding the theme function.

Flying Drupalist’s picture

Flying Drupalist commented

works, thank you.

deviantintegral’s picture

deviantintegral commented
StatusFileSize
new 285150_show-hide_toggle_6.x_7.patch4.87 KB
new 285150_show-hide_toggle_5.x_7.patch4.85 KB

Here is an updated patch and one for D5. I fixed a minor bug in the error checking where the toggle switch would allow strings as they can evaluate to TRUE or FALSE.

AlexisWilke’s picture

AlexisWilke commented
Version: 6.x-2.x-dev » 6.x-3.x-dev
Assigned: Unassigned » AlexisWilke
Status: Needs review » Fixed

This is done in 3.x-dev. I did not use these patches.

Thank you.
Alexis Wilke

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

aren cambre’s picture

aren cambre commented
Status: Closed (fixed) » Active

Needs to be documented.

AlexisWilke’s picture

AlexisWilke commented
Status: Active » Fixed

Closing since this has been working for ages in 3.x.

Thank you.
Alexis

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.