Porting to 6?

Attached is a patch to take the current 5.x version to Drupal 6.x as well as a zip archive containing the complete module. This update is based on the 5.x version posted in this thread: http://drupal.org/node/181484. Read that post for more info about added features and dependencies.

two months ago!

Anything happening?

That mean that's working:)
I've been using it from 2 months without problem and now I've installed on other website. Working perfect.

Guys lets get the version rolling. I like a vast number of others do not know how to patch :(

jquery.jgrowl.js, and jquery.jgrowl.css should not be included in Drupal CVS, as they are available for download from third party servers (this is one of the policy of Drupal.org).

See what reported in the CVS usage policy:

DO NOT include code from a non-Drupal project in the repository. If your module requires non-Drupal code, provide a link to where the other code can be downloaded and instructions on how to install it.

Hilal, and others who don't want to deal with patches, the zip attachment is a complete version of the module. No patching required.

Kiam, understood and agreed. When and if the maintainer ever gets around to updating the repository, then he should feel free to include whichever parts he feels are appropriate. Seeing that it's not yet in the repository though, I think it made sense to include a copy of the jgrowl library to make testing easier.

I'm glad no one seems to be having any major issues with the updates. Hopefully it will go into CVS soon.

gilgabar,

Thank you! It's a shame that JQuery Interface - which this module relies on - is not ready for D6.

Hilal, as far as I know the JQuery Interface library is abandoned and therefore will never work with Drupal 6 (or current and future versions of JQuery for that matter). JQuery UI is the successor to JQuery Interface and has all the same functionality and then some. The updated version of Message Effects in this thread uses the JQuery UI library instead of JQuery Interface. See the JQuery UI Drupal module: http://drupal.org/project/jquery_ui or the JQuery UI website for more info: http://jqueryui.com/.

gilgabar>

Thanks a ton for the info!

What version are you using? the dev or the 6.x-1.2?

Just curious, seen it before too never thought to ask, why is there a folder titled '__MACOSX' in there?

I've been using the 6.x-1.2 version of the jquery UI module and version 1.5.2 of the jquery UI library. If there are issues with other versions of either the module or the library let me know and I'll see what I can do to fix it.

The '__MACOSX' folder you see is an artifact of me working on a Mac. It just contains meta data and is hidden from the user on a Mac, but visible on most every other platform. You should be able to safely ignore it. If you are interested in more details Google is a good resource: http://www.google.com/search?q=__MACOSX

Thanks mate! It works great!

Just a follow up, not sure if this is intended behaviour but message effects is taking over the 'available updates' page in admin inter face.

Play around with the message effects for Drupal error messages, then go to Available updates and check manually for new updates.

Some effects even hide certain installed modules.

That's a result of the update module using the same 'error' class as the messages. I have a fix for it, but I need to spend a little more time testing it before I put it up here. Thanks for noticing that.

No worries. Thanks for looking into it.

Oh also I think the Z-index or whatever its called needs to be fixed. Youtube videos overlap messages.

I'm afraid I can't replicate your issue with YouTube videos. Which effect is it that is overlapping? Which module are you using to embed YouTube videos?

I tested the Embedded Media Field module with a YouTube video and the Growl effect. It worked fine. The growl message was on top of the video. If you can give me more specifics, maybe I can replicate the problem and fix it though.

Hi gilgabar,

Try embedding a few videos from youtube with the embed code directly in the text area and not emfield. That's when I experienced it.

I'm still not having any problems with YouTube videos when I embed directly. Perhaps I fixed something in my dev version. It's attached. Give it a try and let me know.

This version should fix the issues you were having with the update module. It also adds a settings field for warning messages and I ran it through the coder module and cleaned things up in general.

For anyone following along at home there is one issue that I'm having trouble with which appears to be the same as the one in this thread. In certain circumstances the effects are not applied. Message effects does a simple check before loading the javascript to see if there are any messages, if not, it skips loading the javascript so as to avoid wasting resources. The problem appears to be that sometimes messages get passed into the system after that check has happened, so the javascript does not get loaded even though there is a message. You can test this easily if you go to the message effects settings page and change one of the timing field values to some non numeric text and submit the form. The validation message appears without any effects. Another instance you might notice is when your core version is old and the update module is enabled. It will present a warning message on most admin pages which does not have an effect applied when it is on its own.

If anyone has any ideas about how to work around the problem it would be very much appreciated.

gilgabar,

Thanks. I experienced the messages appearing below youtube videos even on emfield(CCK). I experienced this behaviour on the Fire fox browser.

Right now I can live with that, but the dev version not showing messages at times is something I cant apply to my production site.

Just to be clear, the issue with effects not being applied in certain cases is present in both the 6.x version at the top of this thread as well as my latest dev version. The version in #21 above should be the preferred version for anyone using the module as it resolves a few other issues.

And FWIW I'm running into similar issues with the 5.x version. The difference is that validation messages will trigger an effect as they should, but the update module situation is the same as described above and does not. There also appear to be cases in the 5.x version in which the javascript is there, but the effect is still not being applied. So if anyone has any ideas about how to resolve these issues feel free to contribute.

Hilal, try switching your theme to Garland to rule out that the You Tube problems are related to your specific theme rather than this module. I'm using Garland on my dev instance (in Firefox) and not experiencing what you describe.

I believe I've resolved the issue with messages occasionally not having effects applied. Switching to hook_help instead of hook_init appears to do the trick.

Thanks will give it a twirl and report back.

Why is this not up as a DEV release?

Because I am not the maintainer and the guy who is appears to have abandoned the project.

Thanks man. I appreciate your help. Why don't you take over as a co-maintainer or something?

Another question gilgabar, what is the '.DS_Store' file?

edit:

Just looked it up, it's similiar to Mac_OSX thing where the Macs place random hidden folders into anything it accesses.

.DS_Store is used from Mac OS X to contain informations about the directory (such as the way the directory is shown on Finder). As every file whose name starts with a dot is not visible on Mac OS X, the Mac users don't normally know of the existence of such files.

Reported error:
$(".status").effect is not a function
here: #385826: $(".status").effect is not a function

More information?

Are you using the version in #24 above? Are the dependencies installed correctly. Have you tried it with the Garland theme to make sure it isn't a custom theme causing the problems? I need more info about the particulars in order to troubleshoot.

Re: #31, I was able to replicate the problem. It appears to have been a jQueryUI module issue due to a change in the release system for the jQueryUI library. See http://drupal.org/node/362509 for more info. The latest version of the jQueryUI module appears to have resolved the problem.

Hey folks.

Good news! I've been added as a maintainer for this module.

gilgabar: I've taken your patch from #24, and added it into the repository on the new DRUPAL-6--1 branch. I haven't tried to use it yet, but it seems to be a good start for the project.

Okay, I've given it a try on firefox/ubuntu, and it seemed to work fine, so I've set up a development release that should appear soon.

Please, folks, give it a test! I'm interested especially in testing on various flavors of IE.

That's great news. Let me know if you have any questions or if you need a hand with anything. As far as compatibility with various browsers goes that will be a function of the libraries involved more than the module itself: jquery, jquery ui, and jgrowl. From my own superficial level of testing the only issues I ran into were with jgrowl in IE, no rounded corners and some transparency issues. Both can be worked around by using an image for the jgrowl background rather than css. They may also have been resolved in newer versions of the jgrowl library.

Do you have a roadmap or other plans for changes and feature additions?

Thanks for the info on growl.

Do you have a roadmap or other plans for changes and feature additions?

Not yet.

My first interest was in getting some movement on the conversion to D6. I work for pingVision, and my boss is interested in having message effects on the site. She's very happy about you having included growl, btw.

I'm about to go on vacation for a week, but once I'm back I want to look over what we've got for Drupal 5 and 6, and talk to jjeff and see what he had had in mind for the module and then go from there. I'll also want to spend a little time reviewing what the existing tickets other than for Drupal 6 are and what need to be done.

Sounds good.

I attempted to address as many of the issues in the queue as I could with the version I put together. The only part I haven't had time for is cleaning up the administration interface. Specifically making the settings contextual, so irrelevant settings aren't displayed for certain effects. There are a couple of support tickets that may or may not still be relevant.

Why there is no release for 6.x if it's working fine?

Well, two things.

1) There *is* a dev release for 6.x that I just created. But the download thingy for a dev release is only created every 12 hours, so there'll be a little wait until it's downloadable.

2) It's works fine with the light testing I did on my test site, viewed in firefox using the garland theme, and I presume there's been some testing by the other gentleman, whose name I've forgotten for the moment. I'd rather do further testing across several browsers and other themes to make sure that the code is stable and working for everyone.

3-minor) I'd like to move a bunch of the seldom-used code into a dme_image.admin.inc file, so it's only included when changing admin settings. The less PHP code that Drupal has to include as a matter of course the better.

Oh, for... I had to go in and hit *another* button to get it to display on the project page as a release. Ah, well, it's visible now.

Please, try and test!

Using a custom subtheme of ninesixty, when installing the module got a "Fatal error: Call to undefined function jquery_ui_add() messagefx/messagefx.module on line 58"

this is using the 2009-Jul-11 6.x-1.x-dev

i then commented most of messagefx_help, so i could get to the site, i got the error about not installing jquery.ui libs and noticed jquery_ui wasnt marked as enabled, so i disabled messagefx. Downloaded the jquery.ui zip and installed it. Re-enabled messagefx, put the hook_help back as i found it and all was well.

But it totally taking out your site under any situation isn't good.

Easy enough to fix. This patch just checks if jquery ui is enabled before attempting to execute any jquery_ui functions.

#42, #43:
Probably older version have no dependency and when it was overridden, it cause that problem.
But it doesn't make sense to check if jquery_ui module exists if there is dependency (dependencies[] = jquery_ui).
6.x is already ported and committed, I have no any problems with that module under 6.x, if you have any other problems, please report separate issues