The "Subscriptions interface" block causes an XHTML validation error when placed on any page that includes a button for submitting or saving content (for instance, the "Post comment" button in the comment form). This is because the "Save" button in the block is defined with id="edit-submit", resulting in a duplicate ID.

CommentFileSizeAuthor
#2 subscriptions_ui.submit-id.286292.2.patch647 bytessalvis
#1 subscriptions_ui.submit-id.286292.patch703 bytessalvis

Comments

salvis’s picture

salvis
he/his
commented
Status: Active » Needs review
StatusFileSize
new subscriptions_ui.submit-id.286292.patch703 bytes

I see the problem. It occurs on D5 only — on D6, the second id gets a '-1' appended, so they're different.

There exists an #id property, but it's documented as "INTERNAL". It seems to let me specify the id myself — does anyone know if there's a downside to doing this?

salvis’s picture

salvis
he/his
commented
StatusFileSize
new subscriptions_ui.submit-id.286292.2.patch647 bytes

It needs to be a 'submit' element after all...

Grantovich’s picture

Grantovich commented

Not sure if this is still relevant (it's from two years ago), but it seems to answer your question:
http://lists.drupal.org/pipermail/development/2006-January/013025.html

salvis’s picture

salvis
he/his
commented
Status: Needs review » Fixed

Perfect, thanks! Committed to 5.x-2.x-dev.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.