don't underscore the administer permission

Adding coder stuff wasn't very proper, so here's just the fix to the specific issue.

I grepped HEAD, DRUPAL-5, and DRUPAL-5--2 for "administer_actions" and didn't find anything.

However, thanks to you making me second guess myself in IRC, I'm now considering this as the SQL upgrade solution instead if querying out to PHP and re-querying an UPDATE for each role. I'd want to make sure REPLACE() works in pgsql, which would mean it might be a few days before I get my pgsql install back up.

UPDATE {permission} SET perm = REPLACE(perm, 'administer_actions', 'administer actions') WHERE perm LIKE '%administer_actions%';

The upside to the implementation in #1 is that $ret[] will show exactly which role ids were updated where just the above UPDATE won't say anything helpful if debugging. If you don't like the REPLACE() alternative anyway, I still think #1 is RTBC.

You were right, my patches keep getting better, but I've somehow managed to spend several hours on this issue, so I'm done now.

I like this one better than #1. Like I said, there are tradeoffs, but I think this one outweighs #1.

#1

• $ret[] shows which roles were updated
• don't have to worry about support for really old databases having REPLACE()

this one:

• does it in one sweeping query
• doesn't make coder module throw a critical warning about embedded variables in the query (since update_sql() doesn't support parameter replacements)
• REPLACE() is listed in the MySQL 3.23, 4.0, 4.1 Reference Manual (http://dev.mysql.com/doc/refman/4.1/en/string-functions.html#function_re...)

  PostgreSQL is supported only back to 7.3 (http://www.postgresql.org/docs/7.3/static/functions-string.html). PostgreSQL 7.2 doesn't list REPLACE (http://www.postgresql.org/docs/7.2/static/functions-string.html).

  Note that Drupal 5.9 system.install defines

  define('DRUPAL_MINIMUM_MYSQL',  '3.23.17'); // If using MySQL
  define('DRUPAL_MINIMUM_PGSQL',  '7.4');  // If using PostgreSQL
  

  so REPLACE() is good on the base requirements for Drupal 5 anyway based on the db docs.

Tested once again on Drupal 5.9 with MySQL 5.0.51a and PostgreSQL 8.3.3. Some credit goes to morbus for inspiring me to take a quick glance at the access control permissions after I read his rant on "admin userpoints".