I've stolen some simple display ideas from the front_page module and applied them to customerror.

1) The ability to choose between a full or a themed (the default setting) error page for each error. Full pages are complete standalone HTML pages that don't include any of the surrounding theme, whereas themed error pages still include the standard menus and blocks etc. Currently customerror only produces themed error pages.

and

2) The ability to allow PHP code to be included in each error page (defaults to off). This allows more adaptable error pages that change their behaviour depending on circumstances eg who the user is etc. Currently customerror only accepts static content for its error pages.

The default behaviour should stay the same after the patch.

Comments welcome :)

CommentFileSizeAuthor
customerror.diff2.65 KBstyro

Comments

Tobias Maier’s picture

Tobias Maier commented

i make it short:

1)
see this module: http://drupal.org/project/sections
it would be nice if you could improve it :D

2)
see issue: http://drupal.org/node/29286
your solution has some security issues

Tobias Maier’s picture

Tobias Maier commented
Status: Needs review » Fixed
styro’s picture

styro commented

Thanks for your comments Tobias.

I don't use the section module yet - how do you see it could be improved? :)

Regarding the security issues - could you elaborate? Is the standard worry about the site admin having the potential to create their own hole when allowed to enter PHP directly?

If it's more than that, the front_page module would probably need fixing too.

Cheers

kbahey’s picture

kbahey commented

Let me comment on this discussion.

Sections module allows you to theme different sections of the site using different themes. So, in effect it can be used to theme customerror pages.

As for the PHP holes, yes, it is the standard issue of allowing an admin to add their own hole inadverently. Yes, front_page has the potential for this hole too, but it is already there, and we are not adding something new, like you propose for customerror.

styro’s picture

styro commented

Much clearer now - thanks :)

Anonymous’s picture

(not verified) commented
bengibollen’s picture

bengibollen commented
kindsvater’s picture

kindsvater commented
Status: Fixed » Closed (fixed)
kindsvater’s picture

kindsvater commented