The attached patch does three things:

1) Modifes uc_edi.install to delete all the variables this module creates in the variable table. Adds an update() function to remove one bogus variable.

2) Modifies the uc_edi.module function uc_edi_settings_form_validate() to properly validate the order import and export archive directories.

3) Removes/adds spaces to conform to Drupal coding standards.

CommentFileSizeAuthor
uc_edi.patches.tar_.gz1.99 KBtr

Comments

ezra-g’s picture

Status: Needs review » Fixed

Fixed, thanks. In the future it would be very helpful if you could use the -up option in your cvs diffs and split each set of changes into its own patch and issue.

tr’s picture

Yes, I will submit separate patches in the future.

The patch was made with diff -up, following exactly the procedure at http://drupal.org/patch/create . If this is NOT the way things should be done, I suggest that documentation be changed.

ezra-g’s picture

Sorry, my mistake. Thanks!

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.