Unneeded cache_clear_all()

moshe weitzman - July 24, 2008 - 22:43
Project:Calais
Version:6.x-1.4
Component:Code
Category:bug report
Priority:critical
Assigned:irakli
Status:closed
Description

This module does a cache_clear_all() during its nodeapi(insert|update) operations. What is the benefit of this? These calls cost performance.

#1

febbraro - July 25, 2008 - 01:23
Assigned to:Anonymous» febbraro

Not sure what that is doing there. This is a hold over from some older implementation (if I had to guess). We'll get this figured out and in the next release. Thanks for the review.

#2

irakli - July 27, 2008 - 14:34
Assigned to:febbraro» irakli
Status:active» fixed

That code looks like me being paranoid and putting extra cache invalidation. I think Moshe is right and it is not needed. Fixed in CVS.

Thank you.

#3

Anonymous (not verified) - August 10, 2008 - 14:35
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.