Ping This!
Rob Loach - July 24, 2008 - 23:41
| Project: | Service links |
| Version: | 6.x-2.x-dev |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
| Issue tags: | link |
Description
Add a link to Ping This!
| Attachment | Size |
|---|---|
| pingthis.patch | 2.17 KB |
#1
I like this one! I'll attach a new patch since the module changed and the old one does not work anymore...
Thank you.
Alexis Wilke
#2
Okay! There is new patch with the fixes to this patch. Note that the patch by Rob did not work properly. It would go at the right place on Ping.fm, but it would not send the correct URL and would transform the data (teaser) in a rather ugly way!
There are problems with the default l() and hook_links() feature so I had to generate the href by hand.
Now, there are still two issues:
1) The teaser may include local links, we would need to transform those into global links.
2) The teaser may include "ugly" things such as some javascript that would certainly not run after sent to ping.fm...
Other than that, it works great. 8-)
Thank you.
Alexis Wilke
#3
Very nicely done! Thanks a lot for the patch. Any thoughts on using the Service Links 6.x-2.x-dev for this? They have a hook_service_links that makes it very easy to add links with an icon.
#4
I think you should have this patch for ping.fm, then ask Service Links to add Ping This! to their list. There is no reason for them not to add Ping.fm to their list, it is big already!
What do you think?
Alexis Wilke
#5
Great idea!
#6
Whoops, as documented, it should be "body", not summary.
#7
http://drupal.org/cvs?commit=250946
#8
Automatically closed -- issue fixed for 2 weeks with no activity.