bogus integration with alt_login
espie - July 26, 2008 - 13:11
| Project: | Masquerade |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
You guys managed to commit something that doesn't work at all !
Issues:
- the logic for alt_login requires name to be defined! Since you just cut&pasted one of my lines, the result doesn't make sense.
The select never works.
- if you don't patch the auto-select part as well, the patch is of little use anyways, as you have to enter alt_login stuff manually...
#1
patch attached, that makes it work with 1.2...
#2
Fixed patch for 6.x, since I switched.
With this one, both auto-complete and actual changes work.
I think it's simpler than what's currently in.
#3
#521444: Store user ID's instead of user names for quick switch links is a prereq to this
#4
Patch no longer applies.
#5
sigh, I'll work on another patch tomorrow.
But please stop postponing it or applying it in weird ways, it's a bit like having to fix the same bug over three times. It is getting annoying...
#6
For sure - your patches are appreciated. I'd like to get this in to the next release of the module.
#7
I have an updated patch (untested) for this which I'll be posting later today.
#8
Here is an updated patch - can you let me know if it works for you?
#9
#10
Here is a rerolled patch, with a minor code style change.
#11
I've committed this patch as it's works for me and is needed to fully fix the Anonymous users issue.
#12
sorry for not giving you feedback earlier. I got swamped in other issues.
Things appear to work just fine. Thanks a lot !