Convert the admin interface into a real form [#287678]

In smileys_admin_list() the code adds a <form> tag which is superfluous, as it should be added by drupal_render() (which is not the right function to call here, see #287674: Use drupal_render_form).
The HTML ID for the form can be added (even if I don't see the purpose on doing it) with a line like this:

  $form['#attributes'] = array('id' => 'smileys-admin-form');

Comment	File	Size	Author
#4	fapi_admin_list.patch	22.58 KB	gilgabar

Comments

Comment #1

stokito commented 24 August 2008 at 17:22

Ok thanks!

Comment #2

Gurpartap Singh commented 3 December 2008 at 12:05

It isn't superfluous, rather we need to implement the whole interface using fapi, which currently isn't in use, scary? Have a patch?

Comment #3

Gurpartap Singh commented 5 December 2008 at 11:45

Title:

Remove the <form> tag

» Convert the admin interface into a real form

Comment #4

gilgabar commented 12 February 2010 at 07:09

Version:	6.x-1.0-alpha1	» 6.x-1.x-dev
Status:	Active	» Needs review

Status	File	Size
new	fapi_admin_list.patch	22.58 KB

Here is a patch. It reimplements the admin list page using FAPI and theme functions. It also drops some of the ajax stuff that was going on for saving weights and categories (the visibility ajax stuff is still there). From what I could see it was primarily trying to fake a normal form save using ajax, so now that it uses FAPI that shouldn't be necessary. And if for some reason ajax form submission were desired, form.js would be a better route anyway. It also moves the edit/delete commands to an operations column to be more consistent with standard drupal admin tables.