Protect svn files in .htaccess

Uwe Hermann - August 12, 2005 - 21:04
Project:Drupal
Version:5.x-dev
Component:base system
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

The provided patch adds some more files and directories which will be protected by the default Drupal .htaccess file.

First, lots of files and directories used by Subversion (svn), as I keep all my Drupal installations under version control (and Drupal might switch to svn later, too). The database/ directory and *.mysql and *.pgsql, because nobody needs to access those from the web. I removed the update/ directory from the list, there's no such directory in CVS or 4.6., so I guess it's obsolete.

AttachmentSize
htaccess_4.patch895 bytes

#1

praseodym - October 10, 2005 - 17:53

For me .htaccess directory blocking is broken. directory/ is blocked, while directory/file.txt is not. It's clearly ineffective.

#2

Morbus Iff - October 12, 2005 - 03:38
Status:needs review» active

No patch attached.

#3

Morbus Iff - December 1, 2005 - 05:14
Assigned to:Anonymous» Morbus Iff
Status:active» duplicate

-1. When and if Drupal ever uses svn, it'll add this stuff in - until then, it shouldn't cater to your environment. As for database/, it's as innocent as someone requesting CHANGELOG.txt, and has no reason for being blocked. The only thing worthwhile from this patch is the removal of updates - because that's already covered with the .inc. Note: this has nothing to do with directories, only [Files].

Marking as duplicate, see final patch/revisions at http://drupal.org/node/29344.

#4

Uwe Hermann - December 1, 2005 - 14:23
Title:Protect more files in .htaccess.» Protect svn files in .htaccess as soon as Drupal uses svn.
Status:duplicate» postponed

OK, you're probably right. Marking as postponed.

#5

Wesley Tanaka - February 3, 2007 - 06:08
Version:x.y.z» 6.x-dev

subscribing

#6

Gábor Hojtsy - June 7, 2008 - 09:20
Version:6.x-dev» 7.x-dev
Assigned to:Morbus Iff» Anonymous
Status:postponed» needs review

Agreed that SVN directories and files should be blocked. (Possibly even backport to Drupal 6.x).

#7

Morbus Iff - June 7, 2008 - 13:26

New patch against HEAD. Note that the original patch included mostly directories - Apache's FilesMatch (or Files) have never worked against directories. From the original patch, only .svn-base, entries, and format are valid. Also included in this patch is "all-wcprops".

AttachmentSize
28776_svn_htaccess.patch 745 bytes

#8

Morbus Iff - June 7, 2008 - 13:32

Correcting typo.

AttachmentSize
28776_svn_htaccess.patch 745 bytes

#9

lilou - August 22, 2008 - 22:08

Reroll

AttachmentSize
htaccess-svn-7.x.patch 771 bytes

#10

Damien Tournoud - August 23, 2008 - 09:41
Title:Protect svn files in .htaccess as soon as Drupal uses svn.» Protect svn files in .htaccess
Status:needs review» reviewed & tested by the community

A lot of us already use SVN to manage Drupal sites. I'm for this to go in right now.

#11

Dries - August 30, 2008 - 13:22
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#12

Anonymous (not verified) - September 13, 2008 - 13:33
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

#13

jvandyk - November 9, 2008 - 21:06
Version:7.x-dev» 6.x-dev
Status:closed» reviewed & tested by the community

Patch for Drupal 6.

AttachmentSize
protectsvn6.patch 734 bytes

#14

Gábor Hojtsy - November 10, 2008 - 12:05

#15

Gábor Hojtsy - December 10, 2008 - 20:04
Version:6.x-dev» 5.x-dev

Thanks, committed to Drupal 6 given no further pressing needs coming up from that thread. Moving to 5.x.

#16

drumm - December 10, 2008 - 20:12
Status:reviewed & tested by the community» fixed

Committed to 5.x.

#17

System Message - December 24, 2008 - 20:21
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.