CustomError and Drupal cvs (as of 13th August 2005 @05:33 GMT+1)
When I request a page that doesn't exists, a 404 error is executed. it goes to customerror/404. but in the display of the page it displays one site correctly and right below it displays the site again but with the original 404 error from drupal. A screenshot is attached.

CommentFileSizeAuthor
#4 customerror_duplicatepage_customerror.module.patch498 bytesTobias Maier
drupal_error.png15.17 KBSamuel Gordalina

Comments

kbahey’s picture

kbahey commented

Has to be something in your setup.

I upgraded to the latest version from CVS and it does not show the problem you are reporting.

kbahey’s picture

kbahey commented
Status: Active » Closed (fixed)
Tobias Maier’s picture

Tobias Maier commented
Status: Closed (fixed) » Active

I do have the same error
- on my cvs-test site
- on drupaldocs.org http://drupaldocs.org/fasdasdfasdfsdaf

seted the 404-page to any node
--> error never occured
seted back to customerror
--> error back :(

plz fix it
thanks

Tobias Maier’s picture

Tobias Maier commented
Status: Active » Needs review
StatusFileSize
new customerror_duplicatepage_customerror.module.patch498 bytes

i found the error!
it was definitely in customerror

there was print theme('page', $body);
but it should be return $body;
because drupal_not_found() waits for a return and themes the page by itself

ciao tobi

kbahey’s picture

kbahey commented
Assigned: Samuel Gordalina » kbahey
Status: Needs review » Fixed

Thanks for the fix.

Commited to 4.6 and HEAD.

Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)