Posted by joncup on July 28, 2008 at 8:44am
| Project: | Splash |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
Issue Summary
I don't know if this is feasible, but could we have support for lightbox2 in addition to thickbox, also, is thickbox even supported for 5.x?
Comments
#1
+ 1 to this but for D6.
#2
Any particular reason to use Lightbox2 instead of thickbox? We're using thickbox on a D5 site with no problems.
#3
Hi,
Seanr ,thanks for picking up the support and maintenance of splash.
Anyway, I'm not able to get the thickbox to work in 6.x.
Kind regards,
Jim
#4
Lightbox2 is better than thickbox in my opinion. I switched off thickbox a while ago and It's much faster, better looking and a more elegant solution in general. I think people are moving off thickbox and into lightbox2. Take ubercart for example.
I'd like this to be supported as well. I'd also like to remove thickbox from inside this module and instead require thickbox / lightbox module dependencies instead. Selectable "popup" support would be the best.
I was able to get Thickbox working in 6.x, but I did quite a bit custom programming and fixes in my version, so I'm not sure if I fixed this or if it just worked.
This module does need a little bit of clean up work to get it to where it's a viable option for casual users. Thanks for taking over support and I appreciate any future work.
#5
jwilde, can you try it with one of the core themes? It works fine with garland for me, so it may be a theme related issue.
#6
Ok. I tried the thickbox option with garland and nothing happens. I also tried zen and got the same results.
I'll look in to the module more when I get some time. Thanks for your speedy reply.
Kind regards,
Jim
#7
jwilde, can you list your exact settings for all the tabs so I can try to reproduce the problem? Also, do you have any other modules enabled that do anything JavaScript or jQuery related? Also, make sure you've got the latest versions of everything.
#8
I discovered there was a conflict between this module and the thickbox module because this one packaged it's own (and thus dusplicate) copy of the thickbox javascript code. I'm looking into integrating with Lightbox as well, but having a very difficult time due to the way Lightbox2 was designed. I have an issue in their queue seeking assistance: #565554: Invoke Lightbox2 on page load?.
#9
Looking at the lightbox thread, your original issue appears mostly solved. Any chance we could get an ETA on this? I'd loooove to stop using thickbox, seems silly to use it on the front page, then use lightbox everywhere else on the site.
#10
Subscribing
#11
also Colorbox and Shadowbox.
Colorbox is the upgrade path for Thickbox.
#12
+1 for the integration of Colorbox as it is the Thickbox Drupal projet official upgrade. Thanks to let us know if Colorbox is supported as well or not.
#13
+1 for colorbox
#14
+1 for lightbox2
[it's most used and it's loaded with ubercart by default]
#15
+1 for colorbox
#16
changed title
#17
subscribe, +1 for colorbox
#18
Here is a patch for colorbox against the dev version at 2011-Feb-25.
This is the very first time I make patch... Please let me know if there is problem!
This should add the colorbox option in the admin section, and load the colorbox js on document.ready
#19
I would love to test this, but I've moved on to D7. If and when that becomes available I will happily give it a try.
#20
I'm giving a try to these patches, I got this upon patching:
# patch < splash.module-288043-18.patchpatching file splash.module
Hunk #1 succeeded at 197 (offset 1 line).
is this normal?
#21
#18 works with colorbox in Opera, Chrome and Firefox.
It required the size to be set in settings area in order for it to work correctly under Firefox and Opera, but this is no problem at all!
#22
Has anyone managed to get it working with lightbox2? I see that it checks if the module is installed and adds it as an option but there's nothing in the code to suggest it actually works.
I'm thinking of adding a patch but I'm not sure what's the best approach here. As far as I managed to read about lightbox2 you need some
javascriptto simulate a click on a link or add the content inside of adiv. I think the link approach might be the easiest solution: use somejavascriptto add a link to the/splashpage and programmatically click it.Any ideas/suggestions?
#23
As an FYI: I created a drupal 7 module called splashify that uses colorbox by default. Here is the sandbox project: http://drupal.org/node/1425392
I am willing to support other lightbox solutions with this module, but I need help in getting this module approved to become a full drupal project. Here is the issue that covers the project: http://drupal.org/node/1425392