move define()
moshe weitzman - July 28, 2008 - 15:12
| Project: | Teleport |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | incidentist |
| Status: | closed |
Jump to:
Description
you do a variable_get in the global scope. it is: define('TELEPORT_HOTKEY', variable_get('teleport_hotkey', 'T'));.
thats a little undrupalish. please move this code to hook_init(). you don't always know that variable_get() is working when you get included.
#1
Changed the define() to define the default key character, and use variable_get()s where TELEPORT_HOTKEY used to be.
#2
Automatically closed -- issue fixed for two weeks with no activity.