Activating the glossary module seems to break themes.

I first noticed this during the development of a custom theme, then noticed the problem was also present with Drupal-supplied themes.

The attachment is of two screenshots of the settings/module page using the SpreadFirefox theme, with or without the glossary activated: as you can see, activating the glossary breaks the header layout and changes the rendition of the links in the sidebars. Using other themes, the change can be even more extreme. I can't see why the glossary would change styling, though ?

CommentFileSizeAuthor
#6 ThemeBlowsUp.zip78.11 KBwslntheline
#3 GlossaryVsThemes.zip66.95 KBfgm
GlossaryVsThemes.7z67.09 KBfgm

Comments

Ian Ward’s picture

I've experienced similar to this on glossary 4.5. Could it have something to do w/ the dd tags in the css and overlap:hidden? I dont think it does, as i tried it w/o any css and did not improve the situation. Any ideas what else this could be? It makes it unusable, but i'm still unsure of the circumstances that create the problem, because it does not seem many other have this issue...

Ian

moshe weitzman’s picture

please post with something other than .7z archive.

fgm’s picture

StatusFileSize
new66.95 KB

Here they are, in another format.

Ian Ward’s picture

It seems like under some circumstances the opening acronym tag which includes the title text via $term->description does not add a closing ">, which then messes up the template. It is not the length of the description, but maybe some special characters in the description? I've tried it with plain text which has ' and " in the text, as well as some html. There is a check_plain on the $term->description call in the module. I'm not sure why it's not closing.

Ian

Ian Ward’s picture

I have a hunch at what might be causing this problem - when the description contains a CRLF line break in it, which will mess up the title tag on the href, thus leaving the tag open, or closing it where it should not be closed. This effects of this may not be visually present on every node view, but on some node views the template is broken.

Ian

wslntheline’s picture

StatusFileSize
new78.11 KB

I'm having a similar problem, but much worse and in a different area. When a user clicks on a linked glassry term for the definiton, well, my site blows up. See the attached screenshot to see what I mean. I'm using the Blix theme and Drupal 4.7 Beta 4. Looking at the code, it seems that the glossary module is generating the HTML tag again. I'm attaching some sample code too.

shouchen’s picture

I've created a separate issue for this "similar problem". http://drupal.org/node/48074

nancydru’s picture

Status: Active » Closed (duplicate)
sposob’s picture

Version: 4.6.x-1.x-dev » 6.x-1.6

hi!
i just wonder if the module is still maintained, as the last version is from 2008. I installed it now on a drupal system 6.19 and it broke my layout totally. even when i de-activate the module no theme (not even the custom ones) work.

does it make sense to work with this module? is there a replacement that is maintained doing the same? i really like the functionality - it is exactly what we would need.
Thank you very much for your help

Sp~s~b

nancydru’s picture

Yes, it is still maintained, although I have had several significant events in my life over the last two years, including nearly dying.