warning: Invalid argument supplied for foreach()

Hmmm ... maybe too complicated thinking ...

Don't get me wrong, it is a great module!

After the study of cron.php I took all 'message' related lines out and poormanscron-module is working fine since - better without the nasty error messages in the log file.

I'm watching the log carefully and I can't see any impact on other modules after my code change on poormanscron-module.

;-)

Looks like a simple isset() check prior to rebuilding the messages helps (end of poormanscron_exit()). And it should be fine if you dont restore the messages if there arent any messages to begin with.

    // Restore any prior messages.
    if(isset($saved_messages)) {
      foreach ($saved_messages AS $type => $types_messages) {
        foreach ($types_messages AS $message) {
          drupal_set_message($message, $type);
        }
      }
    }

I verfied this somewhat blind guess by changing the watchdog message to this:
watchdog('regular', 'Cron run completed ('.isset($saved_messages).').',WATCHDOG_NOTICE);

If the newsfeed is requested by some anonymous user the message is "Cron run completed()" otherwise its "Cron run completed(1)". So, yea... it might happen that the variable $saved_messages is NULL, which in turn causes that php error message.

HTH :)

Fixed in HEAD and 4-6 (tarballs will be rebuilt in a few hours). Please reopen if there are problems.