Posted by hanoii on July 28, 2008 at 6:12pm
| Project: | Simplenews on register |
| Version: | 5.x-1.2 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
I also needed the descriptions in registration form as in #283515: Newsletter Description on Registration Form and I also needed configurable weight for the newsletter form addition so I can decide where to put it in my registration form (I have profile fields set up for registration as well).
Attached is the patch, I will flag the other issue duplicate and point it here.
You may wish to review the wording of the description text for the configurable weight element.
| Attachment | Size |
|---|---|
| simplenews_register.patch | 2.08 KB |
Comments
#1
I've submitted the configurable weight portion of this patch to CVS.
As for adding the term's description, I would prefer that was configurable. I'm marking as CNW for that portion.
#2
Ok, I have changed the patch to include a configuration option for showing the description. This configuration is per newsletter so it's rendered in the table with the other settings.
Hope this gets through to the CVS.
a.=
#3
Thanks hanoii. Patch was submitted to CVS.
#4
Great, just by curiosity I check the CVS log and noticed it was committed to DRUPAL-6 branch, can you possibly apply it to DRUPAL-5? The patch is against the D5 branch anyway.
Thanks,
a.=
#5
Needs backporting to D5.
#6
But the patch I submitted is against the D5 branch, it works for D5.
#7
Applied to CVS on D5.
#8
Automatically closed -- issue fixed for 2 weeks with no activity.