node.module can be disabled; but the server breaks if this happens [#28827]

node.module is a critical module, because everything is based on nodes. I'd even consider saying that the module is really part of the very core of what makes Drupal Drupal -- since without nodes, there is very little content.

This module can be disabled in the modules. But a LOT of modules use node_ functions -- such as node_load() -- without checking to see if the module is active. If one of these modules is enabled, and node.module is disabled, all pages will stop on a PHP error.

I think the node module should be set to required.

Comment	File	Size	Author
#3	required_node.patch	359 bytes	merlinofchaos
#3
#1	system_7.patch	661 bytes	Uwe Hermann
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Uwe Hermann CreditAttribution: Uwe Hermann commented 21 August 2005 at 12:42

Version:	4.6.0	» x.y.z
Assigned:	Unassigned	» Uwe Hermann
Status:	Active	» Needs review

File	Size
system_7.patch	661 bytes

I'd say merlinofchaos is right. Here's a patch.

Comment #2

merlinofchaos CreditAttribution: merlinofchaos commented 26 October 2005 at 18:32

Simple patch, works fine for me. +1

Comment #3

merlinofchaos CreditAttribution: merlinofchaos commented 15 December 2005 at 23:58

Status:

Needs review

» Reviewed & tested by the community

File	Size
required_node.patch	359 bytes

Rerolled the patch against current CVS. This really ought to go in.

Comment #4

chx CreditAttribution: chx commented 16 December 2005 at 00:05

Status:

Reviewed & tested by the community

» Needs review

Not so fast. Let's see what breaks. Is this an absolute necessity?

Comment #5

Wesley Tanaka CreditAttribution: Wesley Tanaka commented 16 December 2005 at 04:35

perhaps a red herring:

i don't fully like nodes, primarily because if you don't assign a url alias for every single one, they all show up as the vague url 'node/12345', whatever type they actually are. they also require all the content that's represented as nodes has a row in the {node} table, which could be a lot of rows, even if they were split among many different types. if i weren't using the drupal forums, (and had i understood them better before starting to build some of my custom modules) i might not even use nodes on my site.

i think it's an attractive part of drupal that you could turn that module off if you wanted to. makes it feel more modular.