The module works great, however, if there's no shippable products on your shopping cart, the delivery panel don't appear, and you end up with a extra "Select Address: " select at the very bottom of the check out form.

i tweaked a bit the module to avoid this problem, not sure if its the best way to solve it ( not sure if im the only one having this problem ), anyway, the fix is on the .patch file attached.

// $Id: uc_addresses.module,v 1.1 2008/05/26 20:55:29 freixas Exp $

CommentFileSizeAuthor
uc_addresses_no_delivery.patch1.65 KBwebalab

Comments

webalab’s picture

webalab commented
Status: Active » Needs review

Forgot to mark it as ready.

freixas’s picture

freixas commented
Assigned: Unassigned » freixas

Hi,

The patch failed because the module you are using is quite old. I believe the gist is that you are bracketing the delivery address with:

      if ($form['panes']['delivery']) {
        ..
      }

I've added this code, but haven't had a chance to test it out. If I checked it in, would you be willing to check out the latest CVS and test it out?

I'm not sure if this is the best solution, but it looks reasonable.

EDIT: I should have added that I had a problem with my CVS structure. Until just recently, the 5.x-1.x-dev was very old, much older than the 1.0 version. This has been fixed.

freixas’s picture

freixas commented
Status: Needs review » Fixed

Changed checked into CVS. Please wait for a dev build dated 2008-aug-1 or later and let me know if this fixes your problem.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.