It seems that no index is being created on the database table 'image' when this module is installed.

Function image_schema() in image.install does not define an index!

This could make things very very slow with more than a few images installed.

Thanks.

CommentFileSizeAuthor
#6 image-HEAD.image-indexes.patch2.3 KBsun
#4 image-indexes.patch6.31 KBmustafau
#3 image.install.patch1.01 KBsmk-ka

Comments

AltaVida’s picture

AltaVida commented

edit:

"This could make things very very slow with more than a few images installed."

err, um. You know what I mean ;-)

AltaVida’s picture

AltaVida commented

Any feedback on this? It seems like a pretty important issue.

Cheers.

smk-ka’s picture

smk-ka commented
Version: 6.x-1.0-alpha2 » 6.x-1.x-dev
Assigned: Unassigned » smk-ka
Status: Active » Needs review
StatusFileSize
new image.install.patch1.01 KB

Please test.

mustafau’s picture

mustafau commented
StatusFileSize
new image-indexes.patch6.31 KB

Updated the patch. Added an update function.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work

Well, the module update function was a good idea. However, removing all other contents in that file was not. Please re-roll.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Fixed
StatusFileSize
new image-HEAD.image-indexes.patch2.3 KB

Committed attached patch.

scroogie’s picture

scroogie commented

May I ask why you don't define a combined index on both fid and nid?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.