Taxonomy term aliases are build against incorrect source paths

When a taxonomy term alias is built (and deleted) it is done based on the assumption that the term path is taxonomy/term/123 (unless its a forum!).

The reality is that the term path should be determined using taxonomy_term_path.

Here are some patches...

This one patches the pathauto module so it correctly - if inefficiently - removes ALL term paths (+ feed paths).

Index: pathauto.module
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/pathauto/pathauto.module,v
retrieving revision 1.44.4.101
diff -u -p -r1.44.4.101 pathauto.module
--- pathauto.module     24 Jun 2008 16:04:11 -0000      1.44.4.101
+++ pathauto.module     29 Jul 2008 15:45:38 -0000
@@ -332,10 +332,23 @@ function pathauto_taxonomy($op, $type, $
         case 'delete':
           // If the category is deleted, remove the path aliases
           $category = (object) $object;
-          path_set_alias('taxonomy/term/'. $category->tid);
-          path_set_alias(taxonomy_term_path($category));
-          path_set_alias('forum/'. $category->tid);
-          path_set_alias('taxonomy/term/'. $category->tid .'/0/feed');
+         $forum_vid = variable_get('forum_nav_vocabulary', '');
+         if ($forum_vid == $category->vid) {
+            path_set_alias('forum/'. $category->tid);
+           path_set_alias('taxonomy/term/'. $category->tid .'/0/feed');
+         }
+         else {
+            path_set_alias('taxonomy/term/'. $category->tid);
+           path_set_alias(taxonomy_term_path($category));
+           path_set_alias('taxonomy/term/'. $category->tid .'/0/feed');
+           path_set_alias(taxonomy_term_path($category) .'/0/feed');
+
+           $feedappend = variable_get('pathauto_'. $module .'_applytofeeds', '');
+           if (!empty($feedappend)) {
+              path_set_alias('taxonomy/term/'. $category->tid .'/'. $feedappend);
+             path_set_alias(taxonomy_term_path($category) .'/'. $feedappend);
+           }
+         }
           break;
         default:
           break;

This patch fixes the feed alias path generation which assumes the feed should be generates using taxonomy/term/*/0/feed. Not ALWAYS the case - sometimes you may have that vocab controlled by a view.

Index: pathauto.inc
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/pathauto/pathauto.inc,v
retrieving revision 1.1.2.51
diff -u -p -r1.1.2.51 pathauto.inc
--- pathauto.inc        18 Jun 2008 20:05:08 -0000      1.1.2.51
+++ pathauto.inc        29 Jul 2008 15:45:38 -0000
@@ -321,8 +321,9 @@ function pathauto_create_alias($module,

     // For forums and taxonomies, the src doesn't always form the base of the rss feed (ie. image galleries)
     if ($module == 'taxonomy' || $module == 'forum') {
-      $update_data = _pathauto_existing_alias_data("taxonomy/term/$entity_id/$feedappend");
-      _pathauto_set_alias("taxonomy/term/$entity_id/$feedappend", "$alias/feed", $module, $entity_id, $update_data['pid'], $verbose, $update_data['old_alias']);
+      $src_path = ($module == 'forum') ? "taxonomy/term/$entity_id/$feedappend" : "$src/$feedappend";
+      $update_data = _pathauto_existing_alias_data($src_path);
+      _pathauto_set_alias($src_path, "$alias/feed", $module, $entity_id, $update_data['pid'], $verbose, $update_data['old_alias']);
     }
     else {
       $update_data = _pathauto_existing_alias_data("$src/$feedappend");

The other issue to get this solves is patched in #278368: taxonomy_term_path being passed TID instead of Term Object. There is an issue where the term ID is passed (rather than the term object) to taxonomy_term_path.