I found several small coding style fixes and some code improvements that were present in D6-Alpha3 but not in D5-Alpha3.

This patch brings D5-alpha3 "almost" in sync with the D6 alpha3 version... please review.

Other pending fixes to finish synching D5-alpha3 (not included in attached patch):

  • The SolrPHPClient directory seems to be out of date in D5-alpha3
  • The tests directory seems to be out of date in D5-alpha3

Oh, and I found that schema.xml in D6-alpha3 is missing a $ in the $Id$ line =)

CommentFileSizeAuthor
sync_d5alpha3-to-d6alpha3.patch26.17 KBjanusman

Comments

robertdouglass’s picture

robertdouglass commented
Priority: Minor » Critical

janusman: you will close this when you've brought the two in sync?

janusman’s picture

janusman commented

Right. Only thing missing is the SolrPhpClient. Will get to that asap.

robertdouglass’s picture

robertdouglass commented

How are we doing with this effort?

janusman’s picture

janusman commented

Synced everything quite some time ago (about a month?) but I have had some small setbacks, in that some contributors commited old code over already-sync'd portions...

So this is an official call for everyone to *always* update their sandboxes before patching and committing stuff =)

I haven't touched the last bit (the SolrPhpClient), will get to checking if sync is still an issue soon.

janusman’s picture

janusman commented
Status: Needs review » Fixed

Checked this today, it seems everything is in sync between DRUPAL-5 and DRUPAL-6--1.

"Fixed" then, not by me, but by everyone =)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.