I'm asking for a review of the latest beta release which actually doesn't contain a few textual fixes (so could review dev). I like to see what other features are necessary for the conclusion of the GSoC development cycle. I'm to the point where I think the module has completed the requirements laid down at the beginning of the summer..

Further improvements have been discussed and will be developed, but I would like to release a 1.0 version of this module as a placeholder for GSoC development and to separate further development.

I also would like to open up the module to other developers if they wish to help, but I feel that somewhat violates the GSoC idea so I would like to get that wrapped up. It is coming closer to the end of the timeline anyway.

Through IRC conversions Bojhan and I came to the conclusion that the module is complete for GSoC purposes, so I'm looking for Bevan and possible webchick's approval/thoughts.

Comments

Bevan’s picture

Bevan commented

Great! I will try to find time today or tomorrow for another full review using the module. I'll also try to do some code review. Have you run it through coder module?

There are still 2 weeks left for the GSoC program. Please consider starting some of the other features discussed, e.g. robotreplay integration, invite mailing system, mouse tracking, also perhaps simpletests? It's not necessary to finish these within the GSoC timeframe, since you've already completed the goals laid down at the beginning (which it seems like you have). But having some base code with loose end that others could adopt would help encourage more to join in and help develop this further.

Lastly, do you mind if I blog this?

boombatower’s picture

boombatower commented

Blog is fine.

I can finish the mail invites system as I have added a bunch of mail handling code already. I also have a simpletest in place, I will update it. As for starting on the other steps I would much prefer if those were done after some sort of GSoC cut of was completed.

I haven't run it through coder yet since it doesn't have a stable 6.x release. I'm fairly sure I follow the coding standards, but I can try running coder dev tarball.

Bevan’s picture

Bevan commented

okay, sounds good!

boombatower’s picture

boombatower commented

Ran coder nothing other than concatenation issues which I used the new format. Asked in IRC and confirmed that it is fine for contrib to use new format even in 6.x branches.

Made an issue #288771: Appending syntax.

boombatower’s picture

boombatower commented

Invitation functionality added.

Bevan’s picture

Bevan commented

Sorry I won't be able to review today as planned. Most likely tomorrow I will or Saturday at latest. Is my review holding you up at all?

boombatower’s picture

boombatower commented

Nah, I'll just finish updating the tests and then work on other projects.

boombatower’s picture

boombatower commented
Status: Active » Fixed

Addressed by #290271: Review of beta 1

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.