Posted by bjacob on July 30, 2008 at 9:03am
Jump to:
| Project: | Blog reactions |
| Version: | 5.x-1.3 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | sanduhrs |
| Status: | closed (fixed) |
Issue Summary
I've unchecked Blogsearch and Bloglines on admin/settings/blog_reactions. Despite of my settings the services are queried and the results are inserted into the database. I'm not a talented programmer but I think it has something to do with the conditions in blog_reactions_fetch(). For example IMHO
if (in_array('blogsearch', $services)) {is always true. Shouldn't we change it to
if ($services['blogsearch']) {
Comments
#1
You're absolutely right.
Fixed and commited to 5,6,HEAD.
Thanks.
#2
Automatically closed -- issue fixed for two weeks with no activity.