Instead of just passing in the event and the number of points, lets pass in the entire params array and allow other modules to have more fun with the points.

This patch adds the params array as a fifth argument onto the hook call, the origional number of points and event are left in place to maintain the API compatibility.

CommentFileSizeAuthor
add_params_to_hook.patch1.26 KBmdixoncm

Comments

jredding’s picture

jredding commented

+1 (with exceptions)... yaaay!!

Your patch does this...

$rc = module_invoke_all('userpoints', 'points before', $params['points'], $account->uid, $params['event'],$params);

I understand that you were going for backward compatibility but its repeating a lot of data. What if we just shortened it to 

$rc = module_invoke_all('userpoints', 'points before', $params);

and make this a distinguishing feature from version 5.x. I know that it will break a lot of contributed modules but that's OK as they need to be upgraded anyhow (and this little change is a minor coding point).

It makes it cleaner for the future....

mdixoncm’s picture

mdixoncm commented

Sounds perfect to me - yup I was only going for backwards compatibility to make things easier, but your method is definitely much better :)

jredding’s picture

jredding commented
Status: Needs review » Fixed

implemented in version 6

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.