On running the update script I get
* user warning: Table 'drupal.spam_log' doesn't exist query: ALTER TABLE spam_log ADD trid int(11) UNSIGNED NOT NULL DEFAULT '0' AFTER lid in /var/www/html/includes/database.mysql.inc on line 172.
* user warning: Table 'drupal.spam_log' doesn't exist query: ALTER TABLE spam_log ADD INDEX trid (trid) in /var/www/html/includes/database.mysql.inc on line 172.
* user warning: Table 'drupal.spam_tracker' doesn't exist query: SELECT cid FROM comments c INNER JOIN spam_tracker t ON c.cid = t.content_id wHERE t.content_type = 'comment' AND c.status = 1 AND t.score >= 86 in /var/www/html/includes/database.mysql.inc on line 172.
* user warning: Table 'drupal.spam_log' doesn't exist query: ALTER TABLE spam_log ADD KEY (message); in /var/www/html/includes/database.mysql.inc on line 172.

Then when I look down at what was executed I show:
Update #5300

* RENAME TABLE {spam_tracker} TO {old_spam_tracker}
* RENAME TABLE {spam_tokens} TO {old_spam_tokens}
* RENAME TABLE {spam_custom} TO {old_spam_custom}
* RENAME TABLE {spam_reported} TO {old_spam_reported}
* RENAME TABLE {spam_log} TO {old_spam_log}

Update #5301

* Failed: ALTER TABLE {spam_log} ADD trid int(11) UNSIGNED NOT NULL DEFAULT '0' AFTER lid
* Failed: ALTER TABLE {spam_log} ADD INDEX trid (trid)

Update #5302

* CREATE TABLE {spam_statistics} ( stid int(11) UNSIGNED NOT NULL AUTO_INCREMENT, name varchar(64) NOT NULL DEFAULT '', count int(11) UNSIGNED NOT NULL DEFAULT '0', timestamp int(11) UNSIGNED DEFAULT '0', PRIMARY KEY stid (stid), UNIQUE KEY name (name) ) TYPE=MyISAM /* 40100 DEFAULT CHARACTER SET utf8 */;

Update #5303

* No queries

Update #5304

* Failed: ALTER TABLE {spam_log} ADD KEY (message);

This makes sense. It appears the update renames the tables, then doesn't create new ones. I'll try to make a new install file and post it.

Comments

halftone’s picture

I have just had the exact same problem during upgrade of a Drupal 4.7 site -> 5.10 using Spam 5.x-3.0-alpha

Twice, actually, since it's a test upgrade of a copy of a live site, and I've gone through the process twice in case I'd made a mistake.

jeremy’s picture

Title: Upgrade fails from 5.x-1.1-2 » Upgrade fails from 5.x-1.x
Assigned: Unassigned » jeremy

The upgrade from 5.x-1.x was never tested or finished. Assigning to myself, as this needs to be fixed before we can go into beta.

jeremy’s picture

Status: Active » Fixed

Finally fixed in the 5.x-3.x devel tree, it is now possible to upgrade from the 5.x-1.x spam module. (sorry, this didn't make -alpha7).

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.