Closed (works as designed)
Project:
Plus 1
Version:
6.x-1.0
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
30 Jul 2008 at 19:58 UTC
Updated:
13 Jan 2011 at 17:16 UTC
Jump to comment: Most recent file
Comments
Comment #1
Chill35 commentedOh yeah. Much needed. I will put that in, and also make the widget more sexy out of the box.
Thanks!
Comment #2
Chill35 commentedComment #3
idflorin commentedYes is needed, but optionally from config interface.
Comment #4
tuti commentedAny idea of when -1 will be added?
Also, I'd like to request that you could show how many plus and minus votes have been voted not just the result of plus votes - minus votes.
This function would make this module have a unique feature that (to my knowledge) no other voting module has.
Should I make a seperate feature request for this or will this do?
Cheers!
Comment #5
Babalu commentedsubscribing
Comment #6
freshaspect commentedThis would definitely be a very useful addition. Subscribing.
Comment #7
Chill35 commentedI have been told that a -1 that actually substracts an entire vote is a bad idea because that's not how Digg does it.
Someone told me:
That's something I could do. And have the actual subtraction percentage configurable on the module page.
I wonder if you guys are ok with a plain Minus 1 functionality for now, the functionality would be optional of course.
Comment #8
freshaspect commentedI think plain minus 1 functionality would work fine for now. Making the downgrade weighting configurable will make a nice addition but I would argue is a less critical use case.
Paul
Comment #9
Chill35 commentedThanks Freshaspect, I will start with that. I am gonna have some free time Sunday to get crankin' on that.
Comment #10
Chill35 commentedI have worked a few hours on this and have been unable to figure it out.
I am able to record "-1" votes in the Voting API table without problems, however when votes are calculated by the Voting API, the -1 is treated like +1.
There seems to be a problem with the Voting API.
If one of you is able to figure it out and submit a patch, you are welcome.
Comment #11
ingacosta commentedI think we should take these features separately. That is, on one hand add all the negative votes, and secondly, all the positive votes.
Comment #12
ingacosta commentedOr maybe adding a second box for negative votes. It would be very useful for my site. Great module!
Regards
Hernán
Comment #13
freshaspect commentedReally want to get minus 1 up and running...
Is there any chance of making a dev version available that has the minus one stuff in it - even if the votingapi is recording down votes as up votes? We can then work out the best way of fixing this up...
Thanks,
Paul
Comment #14
pfahlr commentedI made a patch against 2.4 that allows for minus 1. I needed this for a site where users can vote against or for an article.
Modified
plus1.module
- added a new setting field to enable voting against a node
- added additional input variable ($amount) to plus1_vote page callback
- modified theme_plus1_widget() to display vote against box if user has not voted and voting against is enabled
jquery.plus1.js
- now removes second widget when a vote occurs
plus1.css
- floated the widgets so they appear side by side
down.png
-new file - flipped up.png for vote against widget
Comment #15
pfahlr commentedI just now read post 10 after the fact. The value field in the votingapi_vote table is type float and not unsigned. When I look at the votingapi_cache table, it appears to be storing the values correctly. I haven't really worked with voting API much as of now. As I mentioned in my last post, I'm currently building a site that requires this functionality, so I'll keep everyone posted on what I find.
Comment #16
pfahlr commentedRE:#10
I think I figured this out, or at least I found another problem. When I truncate votingapi_cache, and run votingapi_select_results(), the results come through in a different order with the result for count instead of average first. In plus1_vote, you're calling votingapi_select_results() and setting only the content_id criteria, so the array you get back has all three count, average, and sum. Then drupal_json() is called passing score as $results[0]['value'] which is unreliable.
On further inspection I found plus1_get_score() which encapsulates this whole process returning just the score. This patch replaces the direct call to votingapi_select_results() with plus1_get_score() and adjusts the following call to drupal_json() accordingly.
I'm going to post another patch for minus 1 functionality shortly that fixes this problem and some javascript/css issues that arose when I added a second button.
Comment #17
pfahlr commentedThis patch adds minus 1 functionality and fixes the issue mentioned in post #10. The widget is displayed as a single box with up and down arrows when minus 1 is enabled. The html/css/javascript setup is better than the earlier version as I noticed some issues when I went to theme it.
Comment #18
tobiassjosten commentedThis patch works well for me.
Comment #19
dixon_Any updates on this issue? Does it need a reroll (havent tested the patch my self yet). Any plans to commit this?
Comment #20
emattias commentedWill the new -1 functionality be able to tally both the number of +1 votes and -1 votes seperately and not just keep a positive - negative votecount?
I'd like to be able to display the number of positive and negative votes for a node or even a percentage of the total number of votes have been positive and negative, but that can easily be accomplished if you get both positive and negative votes..
Comment #21
philbar commentedThis feature is already integrated with the similar module Vote Up/Down.
No point in duplicating functionality of an existing module when it is not necessary.
Comment #22
nancydru@philbar: I totally agree. There is also an issue to merge the modules. This work is just not needed here.
Comment #23
nancydruIf you need this, file an issue to convert to Vote Up/Down module.
See #445274: Need 0 for a "0" request.