Port to 6.x

Thank you for working on this, andypost.

Unfortunately I've been working on the module for much of the day today and this patch is no longer relevant - there are major changes, including the addition of two new blocks: one displays the most recent status updates of users with whom the current user has a specific kind of relationship (set by the administrator), and the other displays the most recent status updates of all users. Adding these blocks involved adding one extensive new function and tremendously modifying facebook_status_get_status() as well as changing the admin settings form.

However, I'm not planning on adding anything new after this, really, so if you don't mind rewriting your patch for the new version I'm more than happy to take a look. A few notes:

• I will not review this unless you attach it in some kind of patch format. I really don't care whether it applies cleanly or not because I'll probably be applying it by hand anyway; I just need a way to see the changes you've made clearly.
• I will not accept a removal of the AJAX feature, but in the latest version I have added an option to the configuration page to turn it off.
• I would prefer if you would open a separate issue for adding the status to the user profile. I think it's a good idea, but I'd like to add it into both the 5.x and 6.x branch.

Cheers!

I've just committed a 6.x branch that should work, although I haven't tested it at all. Please let me know if it works for you once the tarball gets updated.

hm.. seems you committed the branch incorrectly.

What you needed to do was in smartCVS click on tab/branch >> create branch. In the popup, give it the name of DRUPAL-6--1. Make sure the stick to newly created branch button is ticked and clicked ok.

Now, just replace the files with the ones for drupal 6, and commit.

To add this new branch to your projects listings, go to Project >>check out and find the module. In checkout options, choose "retrieve tag branch (new sticky)", click the three dot "browse" button at the end of the textfield and choose the correct branch (DRUPAL-6--1).

In project settings make sure it saves the stuff to a different folder than for the drupal 5 branch you already have.

Yeah--I really messed things up. I updated all the files except the JS last night and tried to commit facebook_status-1.x-dev but only the .module file was included for whatever reason. :/ The 6.x files didn't get updated at all.

Hopefully I've fixed all the issues. Until the packaging script updates everything I've changed the module's front page to provide a direct download.

Thanks for walking me through all of this, and the offer to be a co-CVS maintainer still stands. ;) I'll still be the one working on the code.

Okay, it didn't work and I have no idea what to do about it. The tarballs refuse to update and I can't add another branch/tag (yes I understand the difference).

Sorry for my noobishness. :( But seriously, this is ridiculous.

you need to add another release for drupal 6.

looking on your releases page, the last update on the drupal 5 dev releases is for yesterday and it seems like it is from after your last changes so that should be good.

(in short, you need a release for every tag/branch you want a release for...)

There is a 6.x release, but you can't see it because it's looking in the wrong place for the files; and there is a 5.x-1.x release, but it contains only an outdated .module file.

k, add me on with cvs priviledges and I will try to sort the cvs side out.

Done.

hm... IDeleted the files on HEAD inside the "facebook_status_6x" folder... for the rest I cannot tell what is wrong.

Best start an issue on drupal infrastructure as potentially both of them will need input from there there.

As for why the 5.x-1.x-dev is only containing two files, I noticed that there is another facebook_status module folder there... in "drupal/contrib" instead of "drupal/contrib/contributions/modules/" and that may be confising the drupal.org scripts. (That folder has only those two files...)

So, start an issue off. Request that that other folder (and the facebook_status_6x) is deleted. There may be more to it, but that is the best place to ask.

If you need to change the module name/location as part of this, consider something like user_status instead - it will not restrict you as much in the future if you get an OMG BRILLIANT idea that has not been implemented by facebook. (Hey, I never watched the TV show called Firefly for a long time because it had a wierd name!)

PS this module may have competition with the module called "Dodge", but that is aiming more towards twitter. (don't get me started on that name!). (by "may" I mean that I have used neither, but from descriptions there seems to be some overlap)

I started an issue.

It might be a good idea to change the module's name, now that you mention it. We'll see what happens.

And since you point it out, Dodge does look pretty similar, although I would never have thought of it that way. I think there are arguments for both to exist though, even if the functionality does overlap. I especially hope that facebook_status will benefit once I get some time to look into integration with Activity and Views, and maybe Mailhandler as well.

I'm going to mark this fixed, because even though I haven't gotten the code committed properly, a 6.x version still exists and (as far as I know) is working.

If I don't get a response from a CVS admin within a day or two, I'm going to switch module names. If that happens, I apologize in advance for the confusion.