It would be really nice to get this module ported to Drupal 6, along with any changes required by the new versions of CCK and Event. I'm not using this code on D6 myself, so it will be done quicker if someone else takes this on :).

--Andrew

CommentFileSizeAuthor
#1 resource_conflict.patch3.56 KBkenorb
#1 resource_conflict_6.x.zip12.14 KBkenorb

Comments

kenorb’s picture

kenorb commented
Status: Active » Needs review
StatusFileSize
new resource_conflict_6.x.zip12.14 KB
new resource_conflict.patch3.56 KB

Version for 6.x
But not tested yet.

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented
Status: Needs review » Needs work

Sounds good since now I'm looking for that type of resource conflict for a studio.

Unfortunatly, this version does not fire up any warning on resource conflict, ie, it let the user add the same resource to two different events using the same time range, or part of the time range.

The administrative portion in content type editing works well. It can detect when proper modules are added, event enabled and node reference added.

To test out I created a resource type, added a single resource to it. In the event type, I've added a node reference to the resource. I then created two events using the same time period with start and end and assigned the same resource to the two events. Both events were saved normally.

So most of this module is working. It just does not warn of conflict when needed.

Note: I did use the complete version "resource_conflict_6.x.zip", which is already patched for D6.

deviantintegral’s picture

deviantintegral commented

I'm also thinking that CCK Date support is probably broken. For Drupal 6, there is only Date 2, not Date 1, and at the moment this module only supports Date 1. This issue is really co-dependent with #336705: Upgrade Date API integration to work with Date 2 API.

@xmacinfo: Does it still let you create the event, or does it not just show the error?

I'm going to set up a Drupal 6 release in CVS so there's somewhere to play. I'll post here when I have the release nodes set up.

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented

@deviantintegral: Yes, I can create the events. For each event I'm using the same resource, But the system never send a warning when a resource is already used. So I think it does not check for date conflicts.

deviantintegral’s picture

deviantintegral commented
Status: Needs work » Fixed

Ok, now that the script has run I've created a new issue with the proper version: #345349: Event dates aren't checked properly. For any other bugs found in the Drupal 6 port, please open new issues rather than using this one.

The D6 version was committed to HEAD in #158134.
Thanks!
--Andrew

kenorb’s picture

kenorb commented
Status: Fixed » Needs review

There is some function date_show_value() which should be reviewed.
Normally in Date 2 it doesn't exist anymore, so I've tried to copy it from previous version of Date, but it probably doesn't work.
See issue here: http://drupal.org/node/343218
So I don't know how to backport this function.
In other hand it's very easy and there are no any dependencies, but maybe I'm wrong.
I've left conversation to 6.x, because it was not working at all for me and I don't want to send more time for conversion than it could take make it from the beginning.

kenorb’s picture

kenorb commented
Status: Needs review » Fixed
kenorb’s picture

kenorb commented

See here: http://drupal.org/node/336705

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.