mailman_manager_admin_form_submit not returning, using drupal_goto instead?

metareason - July 31, 2008 - 09:22
Project:Mailman Manager
Version:5.x-1.1
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Hi,

Great module. We are writing a related module to automatically create mailman lists using the plesk API and running your forms programmatically using drupal_execute.

Found a bug in mailman_manager_admin_form_submit line 433 - the function does not return, so when the form is called with drupal_execute it never comes back.

Patch attached that changes the drupal_goto to a return - sorry if it is in the wrong format - we are using SVN to manage our codebase.

Cheers

Mike

AttachmentSize
mailman-return-fix.patch632 bytes

#1

eMPee584 - December 27, 2008 - 15:24
Status:needs review» reviewed & tested by the community

Fix is correct for Drupal-5 form api.

#2

samuelet - December 27, 2008 - 17:57

Committed.
I missed this, thanks.

#3

samuelet - December 27, 2008 - 17:57
Status:reviewed & tested by the community» fixed

#4

System Message - January 10, 2009 - 18:00
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.