Closed (fixed)
Project:
Guestbook
Version:
4.6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
16 Aug 2005 at 00:48 UTC
Updated:
15 Feb 2006 at 20:31 UTC
Jump to comment: Most recent file
Delete/Edit comments links do not work.
My setup: 4.6.2, multisite, default drupal links.
Problem: without URL rewriting, guestbook links are as follows (which is well known)
http://bea/drupal46/?q=guestbook/0
the current code will create invalid syntax for the edit and delete links, for example:
http://bea/drupal46/?q=/guestbook/0?guestbook_deleteentry=0
instead of (note the & instead of the ?)
http://bea/drupal46/?q=/guestbook/0&guestbook_deleteentry=0
the necessary fix appears quite obvious to me, a working version of the module is enclosed for all those needing a quick fix.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | guestbook_2.module | 10.94 KB | Cows4all |
| guestbook_0.module | 11.26 KB | beate_r |
Comments
Comment #1
Cows4all commentedI'm running Guestbook on Drupal 4.6.3.
With the guestbook_0.module I get the following error:
-------------
user error: Unknown column 'g.email' in 'field list'
query: SELECT g.id, g.anonname, g.email, g.website, g.author, g.recipient,
g.comment, g.message, g.created, u.name, u.data, u.picture FROM guestbook g, users u
WHERE g.author = u.uid AND g.recipient = '0' ORDER BY g.id DESC LIMIT 0, 15 in /var/www/html/drupal/includes/database.mysql.inc on line 66.
-------------
Any Ideas? I'm no good in programming...
Comment #2
Cows4all commentedThink that I've fixed it.
I took the original guestbook.module and changed in line 215:
$output .= "
into
$output .= "
So I only changed ? into &.
Don't know what this is different than the patch from mjr, but I got the noted error on that one, and my simple change works fine.
GrTz
Comment #3
hba commentedClean URL patch was just submitted to CVS (for 4.6.0).
Comment #4
(not verified) commented