When I have the module enabled, on many site pages I get the following warning messages:
Using PHP 5.2
Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of module_invoke_all(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /opt/clients/....../html/sites/all/modules/apachesolr/apachesolr.module on line 216
Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of node_invoke_nodeapi(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /opt/clients/....../html/sites/all/modules/apachesolr/apachesolr_search.module on line 88
Is it simply a matter of removing the & in front of the variable?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | call-time_reference.patch | 998 bytes | drunken monkey |
Comments
Comment #1
robertdouglass commented@febbraro: could you look at Senpai's patch here and comment? http://drupal.org/node/270692 Thanks! ... You can reopen the issue too. I'll mark this as duplicate.
Comment #2
drunken monkeyIt seems so, in apachesolr_search.module this has already been done after alpha3. But the one in apachesolr.module is a bit harder, since in PHP4 the & has to be there for the hook to work as expected.
Either we say that people should upgrade to PHP5 anyways and remove the &, or you could remove it manually for your copy.
You could also change the INI directive, but of course that would rather be a setback.
The fourth option would be the attached patch, which kind of inlines the call to module_invoke_all().
Oh, sorry, Robert. Should I post this patch to the other issue, too?
Comment #3
drunken monkey