Move administration code to worldclock.admin.module
| Project: | World Clock |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
I edited the code to make it standards compliant and I have made use of Drupal 6's page handler support to reduce the memory usage of this module. I have not gone deep into all the issues here so I did not make those changes from the issues of this release and I also do not have a patch program so I am including the modified and new files here.
I have also done the uninstall() function to remove this module cleanly from the database.
I would hope that a future release would make use of the page handlers as I have done. This is a great module but it does not warrant such a big memory footprint of about 205,000 bytes for just the display of a block alone. With the use of file inclusions, I managed to reduce the memory usage to only about 46,000 bytes which would greatly reduce the burden on memory limitations by shared hosts. I am sure there is a way to reduce it even further, but I have not really gone deep into your code so I can only do this much before the code breaks.
Thanks for your module once again!
| Attachment | Size |
|---|---|
| worldclock_changed.zip | 6.76 KB |
#1
oh, and I would also hope that this module be kept clean and simple as it is now, without too many extra stuff (as others have been requesting) that may require additional installation or that would increase the module's memory usage even further...
#2
Atuyo,
thanks for the interest you showed to this module.
Are you still interested in contributing? I think most of the issues you fixed here have been fixed through the time or will be addressed in the brand new v2 version.
Hope you still have time to contribute and help with your knowledge!
See you around in the issue queue,
Francesco
#3
Renaming to make the title a bit more clear and setting to v2.