If a user is "blocked" (instead of active) then they probably shouldn't get e-mails. This can be checked when the e-mail is being sent but should also be checked probably in cron and we should delete subscriptions for inactive users in cron.

Anything else?

CommentFileSizeAuthor
#1 289726_nothing_to_blocked_users_whitespace.patch1.68 KBgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Needs review
StatusFileSize
new 289726_nothing_to_blocked_users_whitespace.patch1.68 KB

And here's a patch to do this...

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: no mailing to blocked, periodic cleanup of subscriptions » Don't mail to blocked users
Assigned: Unassigned » greggles
Status: Needs review » Fixed

After thinking about this some more, I realized that maybe it's OK to keep around the subscriptions for blocked users. If that status = 1 becomes an issue on a site then we can reconsider this.

Other than that...this is fixed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.