Posted by twohills on August 1, 2008 at 2:36am
Jump to:
| Project: | NodeReview |
| Version: | 5.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Line 452 $axes[$node_type][$record->aid] = $record->tag;
should read
$axes[$node_type][$record->aid] = $record->aid;
$axes[$node_type][$record->tag] = $record->tag;
Comments
#1
sorry: and...
line 118 of nodereview_node_nodereview.inc, function _nodereview_form_review
'#default_value' => $votes[$axis->tag] ? $votes[$axis->tag] : 50,should read
'#default_value' => $votes[$axis->aid] ? $votes[$axis->aid] : 50,line 174 of nodereview_node_nodereview.inc, function nodereview_load
$record->score = $votes[$record->tag]->value;should read
$record->score = $votes[$record->aid]->value;The confusion arises because voting uses "tag" to refer to the unique identifier of the thing being voted on.
The unique identifier of the axis is the aid not the tag.
In most cases it probably isn't an issue but i am "bending" nodereview and it may be for me (and others).
#2